Cavemanon/SnootGame
25
Fork 18
Code Issues 4 Pull Requests 1 Actions Projects Releases 10 Wiki Activity

Simplifies the gallery code #216

Merged
MapAnon merged 3 commits from Legalo/SnootGame:gallery-of-pain into Patch8-RAGE 2023-01-02 04:53:52 +00:00
Conversation 0 Commits 3 Files Changed 3 +64 -224
GManon commented 2023-01-02 00:20:36 +00:00
Contributor
Copy Link

This PR removes all the unused code, variables and arguments present in the gallery screen including the never implemented zoom function. It also improves some variable names.

This PR might improve the performance somwhat, as Ren'py is predicting the CG gallery screen instead of predicting that weird 'looping' one.

All functionality should still be the same as before this PR.

This PR removes all the unused code, variables and arguments present in the gallery screen including the never implemented zoom function. It also improves some variable names. This PR *might* improve the performance somwhat, as Ren'py is predicting the CG gallery screen instead of predicting that weird 'looping' one. All functionality should still be the same as before this PR.
GManon added 3 commits 2023-01-02 00:20:45 +00:00
Cleans up the gallery ddd003dce0
Removes unused import aba1477600
Prevents exception when emulating the android version through renpy 868487c9b2
MapAnon merged commit 5653d6954e into Patch8-RAGE 2023-01-02 04:53:52 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
needs more info
Something is wrong
question
refactor
Cleaning up the cruft
wontfix
This won't be fixed
bug
Something is not working
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
invalid
Something is wrong
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Cereal Jatmoz Jingo Jluminate Legalo Map MapAnon MichaelYick Mod Nerd Nio nutbuster ReleaseSmith Sl1 TheNerd writerdev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Cavemanon/SnootGame#216
No description provided.
Delete Branch "Legalo/SnootGame:gallery-of-pain"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?