Cavemanon/SnootGame
25
Fork 18
Code Issues 4 Pull Requests 1 Actions Projects Releases 10 Wiki Activity

Naser Drama if/else branch Chapter 11 #78

New Issue
Closed
opened 2021-09-15 03:13:33 +00:00 by nutbuster · 1 comment
nutbuster commented 2021-09-15 03:13:33 +00:00
Member
Copy Link

Currently during 11.school-assignment-and-route-lock

a/f012345
0AAABBB
1AAABBB
2AAABBB
3CCCCBB
4CCCCDD
5CCCCDD

vs storyline.rpy

a/f012345
0AAABBB
1AAABBB
2AAABBB
3CCCCCB
4CCCCDD
5CCCCDD

For the choreography update, do the following:

  • Change 11.school-assignment-and-route-lock.rpy to only have contents before naser drama
  • Split naser drama into 12A.rpy, 12C.rpy & 12D.rpy
  • Put contents after 11.school-assignment-and-route-lock.rpy into 13
  • Move the related ABCD scripts into 14 .. 17 files respectively
Currently during `11.school-assignment-and-route-lock` ``` a/f012345 0AAABBB 1AAABBB 2AAABBB 3CCCCBB 4CCCCDD 5CCCCDD ``` vs `storyline.rpy` ``` a/f012345 0AAABBB 1AAABBB 2AAABBB 3CCCCCB 4CCCCDD 5CCCCDD ``` For the choreography update, do the following: - Change `11.school-assignment-and-route-lock.rpy` to only have contents before naser drama - Split naser drama into `12A.rpy`, `12C.rpy` & `12D.rpy` - Put contents after `11.school-assignment-and-route-lock.rpy` into `13` - Move the related ABCD scripts into `14 .. 17` files respectively
nutbuster added this to the Monster-Update-6 milestone 2021-09-15 03:13:33 +00:00
nutbuster added the
bug
High Priority
 labels 2021-09-15 03:13:33 +00:00
Bowie commented 2021-09-22 19:33:00 +00:00
Member
Copy Link

This was resolved (I think) in my fork in this commit f7b81d2b72, although not in a way that compartmentalises the branched segments into their own .rpy files - can still do this though.

Anywhere that has ending-dependent checks calls a common utility function in f7b81d2b72/game/utility.rpy and checks the return value instead of implementing its own evaluation.

This was resolved (I think) in my fork in this commit https://git.snootgame.xyz/Bowie/SnootGame/commit/f7b81d2b72ca46574c9139b324cdfc43187b3474, although not in a way that compartmentalises the branched segments into their own .rpy files - can still do this though. Anywhere that has ending-dependent checks calls a common utility function in https://git.snootgame.xyz/Bowie/SnootGame/src/commit/f7b81d2b72ca46574c9139b324cdfc43187b3474/game/utility.rpy and checks the return value instead of implementing its own evaluation.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
needs more info
Something is wrong
question
refactor
Cleaning up the cruft
wontfix
This won't be fixed
bug
Something is not working
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
invalid
Something is wrong
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
question
More information is needed
wontfix
This won't be fixed
No Label
bug
High Priority
Milestone
No items
No Milestone Monster-Update-6
Projects
Clear projects
No project
Assignees
Clear assignees
Cereal Jatmoz Jingo Jluminate Legalo Map MapAnon MichaelYick Mod Nerd Nio nutbuster ReleaseSmith Sl1 TheNerd writerdev
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Cavemanon/SnootGame#78
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?