Cavemanon/SnootGame
24
0
Fork 17
Code Issues 6 Pull Requests 2 Projects Releases 5 Wiki Activity

WIP: Fixes #7 - Game should be able to update itself #21

Closed
MichaelYick wants to merge 5 commits from updates into Patchy-Patch5
pull from: updates
merge into: Cavemanon:Patchy-Patch5
Conversation 14 Commits 5 Files Changed 1 +1859 -1850
MichaelYick commented 2021-06-15 09:54:40 +00:00
Member
Copy Link

This PR should address issue #7 and all work on it should be done on the 'updates' branch or forks.

Goals:

  • Menu Option for updating the game
  • Back-end support confirmed to be functional

Non-essential features:
(ordered in top-to-bottom in levels of importance)

  • opt-in auto-update preference
  • Ability to set a prefered update server (i.e if snootgame.xyz ever goes down or moves domain, someone can still update)
  • Integration with torrents
  • support for update via Tor
  • seeding IPFS support
This PR should address issue #7 and all work on it should be done on the 'updates' branch or forks. Goals: - [ ] Menu Option for updating the game - [ ] Back-end support confirmed to be functional Non-essential features: (ordered in top-to-bottom in levels of importance) - [ ] opt-in auto-update preference - [ ] Ability to set a prefered update server (i.e if snootgame.xyz ever goes down or moves domain, someone can still update) - [ ] Integration with torrents - [ ] support for update via Tor - [ ] seeding IPFS support
MichaelYick added 1 commit 2021-06-15 10:01:40 +00:00
MichaelYick added 1 commit 2021-06-15 10:52:29 +00:00
MichaelYick commented 2021-06-15 10:55:22 +00:00
Author
Member
Copy Link

Having trouble getting the python to meld well with the script stuff. Idealy, there should be a loading text, text if there is no update, and text if there is an update depending on what the return of updater.UpdateVersion. Can't really figure this out, so for now its just renpy.notify (and it works as intended). If someone can look into this, offer some advice, or outright do it, that'd be great.

Having trouble getting the python to meld well with the script stuff. Idealy, there should be a loading text, text if there is no update, and text if there is an update depending on what the return of updater.UpdateVersion. Can't really figure this out, so for now its just renpy.notify (and it works as intended). If someone can look into this, offer some advice, or outright do it, that'd be great.
MichaelYick commented 2021-06-15 11:03:34 +00:00
Author
Member
Copy Link

https://f95zone.to/threads/how-to-display-values-on-the-screen.39289/
found a little documentation on what I was working on, would work right now, but its 6 am and these bones need rest. If no one picks up implementing it, i'll get back to it.

https://f95zone.to/threads/how-to-display-values-on-the-screen.39289/ found a little documentation on what I was working on, would work right now, but its 6 am and these bones need rest. If no one picks up implementing it, i'll get back to it.
MichaelYick added a new dependency 2021-06-16 09:26:04 +00:00
#29 Fixes #19 - Extras menu
MichaelYick changed title from WIP: Game should be able to update itself to WIP: Fixes #7 - Game should be able to update itself 2021-06-18 01:57:57 +00:00
MichaelYick added this to the Patchy-Patch5 Release milestone 2021-06-20 04:28:53 +00:00
MichaelYick commented 2021-06-22 18:45:17 +00:00
Author
Member
Copy Link

Been working on this for awhile, mostly waiting UI to be done. Got the functions done and updates.snootgame.xyz is the update server. Still need to test it.

Been working on this for awhile, mostly waiting UI to be done. Got the functions done and updates.snootgame.xyz is the update server. Still need to test it.
MichaelYick force-pushed updates from dffbb9718f to 397de2b950 2021-06-24 01:14:33 +00:00 Compare
MichaelYick commented 2021-06-24 01:18:57 +00:00
Author
Member
Copy Link

Can someone help me out with this PR? For some reason UpdateCheck() runs every damn frame the extra menus is open and crashes the game with an error whenever you click on any button (update has a special error). It is by far one of the werdiest and most frustrating errors. It only occours when the button to call UpdateCheck exists. When commented out, everything just werks.

Can someone help me out with this PR? For some reason UpdateCheck() runs every damn frame the extra menus is open and crashes the game with an error whenever you click on any button (update has a special error). It is by far one of the werdiest and most frustrating errors. It only occours when the button to call UpdateCheck exists. When commented out, everything just werks.
👀 1
coolestskinnieinthejungle commented 2021-06-24 02:37:03 +00:00
Member
Copy Link

pm'd you the fix ;)

pm'd you the fix ;)
coolestskinnieinthejungle requested changes 2021-06-24 02:43:04 +00:00
coolestskinnieinthejungle reviewed 2021-06-24 02:52:54 +00:00
game/screens.rpy Outdated
@ -726,2 +726,2 @@
textbutton _("Enable Automatic Updates") action ToggleVariable("persistent.autoup", True, False)
textbutton _("Update Now!") ##action ("persistent.autoup", True, False) This should also set the value of updateresults
#textbutton _("Enable Automatic Updates") action ToggleVariable("persistent.autoup", True, False)
textbutton _("Update Now!") action UpdateCheck()
coolestskinnieinthejungle commented 2021-06-24 02:52:54 +00:00
Member
Copy Link
- 727 textbutton _("Update Now!") action UpdateCheck()
+ 727 textbutton _("Update Now!") action Function(UpdateCheck)

there's a way to automagically make this a commit that can edit it with the push of a button but i cant fucking remember how

```diff - 727 textbutton _("Update Now!") action UpdateCheck() + 727 textbutton _("Update Now!") action Function(UpdateCheck) ``` there's a way to automagically make this a commit that can edit it with the push of a button but i cant fucking remember how
coolestskinnieinthejungle marked this conversation as resolved
MichaelYick added 1 commit 2021-06-24 23:53:22 +00:00
MichaelYick commented 2021-06-24 23:55:32 +00:00
Author
Member
Copy Link

OKAY SO IT BROKE AGAIN.

I have 2 ways of calling the update implemented, both with their own special snowflake error. Function just has a stroke because of ui context (https://lemmasoft.renai.us/forums/viewtopic.php?t=48945) and Invoke has a stroke because a stack isn't empty and has no way to become empty. It suggest ui.close(), an undocumented, deprecated "fix" that I can't find anything on. I tried manually emptying the stack (probably not a good idea) and it didn't do anything. Renpy's UI work is absolute trash pls halp.

OKAY SO IT BROKE AGAIN. I have 2 ways of calling the update implemented, both with their own special snowflake error. Function just has a stroke because of ui context (https://lemmasoft.renai.us/forums/viewtopic.php?t=48945) and Invoke has a stroke because a stack isn't empty and has no way to become empty. It suggest ui.close(), an undocumented, deprecated "fix" that I can't find anything on. I tried manually emptying the stack (probably not a good idea) and it didn't do anything. Renpy's UI work is absolute trash pls halp.
👀 1
MichaelYick requested review from coolestskinnieinthejungle 2021-06-24 23:55:36 +00:00
Nio commented 2021-06-25 06:19:01 +00:00
Member
Copy Link

It is interesting, apparently updater.update and updater.Update are both existing and somewhat different functions/actions in renpy. https://www.renpy.org/doc/html/updater.html

It is interesting, apparently updater.update and updater.Update are both existing and somewhat different functions/actions in renpy. https://www.renpy.org/doc/html/updater.html
MichaelYick force-pushed updates from f77a2dc953 to e02118180e 2021-06-28 00:44:48 +00:00 Compare
MichaelYick commented 2021-06-29 04:53:28 +00:00
Author
Member
Copy Link

Got everything set up back-end side. Need some people to help me debug it.

Got everything set up back-end side. Need some people to help me debug it.
MichaelYick commented 2021-07-01 05:53:23 +00:00
Author
Member
Copy Link

Okay, im going to leave this feature for now. Stuff is mega broken and im at my wits end about whats wrong. If someone doesn't mind picking it up and helping me out with this, that'd be great. For now, i'll start working on something else.

Okay, im going to leave this feature for now. Stuff is mega broken and im at my wits end about whats wrong. If someone doesn't mind picking it up and helping me out with this, that'd be great. For now, i'll start working on something else.
nutbuster commented 2021-07-01 10:24:57 +00:00
Member
Copy Link

Use update() because updater.update(url, base=None, ..)
is different from updater.Update(*args, **kwargs).
The * star is pretty damn important because the game reads the url as this:

>>> url = 'https://updates.snootgame.xyz/update.json'
>>> url[0]
'h'
Use update() because `updater.update(url, base=None, ..)` is different from `updater.Update(*args, **kwargs)`. The * star is pretty damn important because the game reads the url as this: ``` >>> url = 'https://updates.snootgame.xyz/update.json' >>> url[0] 'h' ```
MichaelYick commented 2021-07-01 15:09:57 +00:00
Author
Member
Copy Link

Use update() because updater.update(url, base=None, ..)

more confusion about the updater fucntions

Pain.

Even with this fix, it's still not detecting a new version being able to be downloaded. I don't know if I did something horribly wrong

The directory structure for the site is as follows:
image

Is something else needed? Does anyone know any free software ren'py projects with updates that we can reference?

>Use update() because updater.update(url, base=None, ..) >more confusion about the updater fucntions Pain. Even with this fix, it's still not detecting a new version being able to be downloaded. I don't know if I did something horribly wrong The directory structure for the site is as follows: ![image]() Is something else needed? Does anyone know any free software ren'py projects with updates that we can reference?
image.png
8.5 KiB
image.png
coolestskinnieinthejungle refused to review 2021-07-01 18:59:47 +00:00
coolestskinnieinthejungle commented 2021-07-01 19:00:43 +00:00
Member
Copy Link

coolestskinnieinthejungle refused to review 1 second ago

shit wrong button

> coolestskinnieinthejungle refused to review 1 second ago shit wrong button
coolestskinnieinthejungle commented 2021-07-01 19:07:26 +00:00
Member
Copy Link

relaying some revalations from convo with Spears to gitea:

so looking at renpy's source code rabbit hole these two methods are called
updater.can_update() and updater.get_installed_packages()
they were calling False and [] respectively causing updater.UpdateVersion("http://updates.snootgame.xyz/updates.json") to return None

so i had to basically generate an "update" directory by building distros & updates from the renpy dev tool, and then stick that directory and it's contents to my build dir

after that those methods were returning True and [u'pc'] so things should be good there now but i'm testing on my wangblows VM and the remote server only has a nix build

tl;dr the workflow is:
build distro + updates
move the updates/current.json dir and contents to ur build/dev project dir

going to get a windongs build on the server in a bit and test to see if i can now pull an update probably on my shitbox. we'll also have to have this shit documented.

relaying some revalations from convo with Spears to gitea: > so looking at renpy's source code rabbit hole these two methods are called > `updater.can_update()` and `updater.get_installed_packages()` > they were calling `False` and `[]` respectively causing updater.UpdateVersion("http://updates.snootgame.xyz/updates.json") to return None > > so i had to basically generate an "update" directory by building distros & updates from the renpy dev tool, and then stick that directory and it's contents to my build dir > >after that those methods were returning `True` and `[u'pc']` so things should be good there now but i'm testing on my wangblows VM and the remote server only has a nix build > >tl;dr the workflow is: >build distro + updates >move the `updates/current.json` dir and contents to ur build/dev project dir going to get a windongs build on the server in a bit and test to see if i can now pull an update probably on my shitbox. we'll also have to have this shit documented.
MichaelYick commented 2021-07-04 01:22:48 +00:00
Author
Member
Copy Link

moving this to https://git.snootgame.xyz/Cavemanon/SnootGame/pulls/48 as this has turned into a hellfire of undocumented renpy

moving this to https://git.snootgame.xyz/Cavemanon/SnootGame/pulls/48 as this has turned into a hellfire of undocumented renpy
MichaelYick closed this pull request 2021-07-04 01:22:48 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
coolestskinnieinthejungle
Labels
Clear labels   
bug

Something is not working

  
Critical Priority

Absolutely urgent issues that must be delt with before others can even be considered.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
High Priority

Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.

  
Low Priority

Minor or easy to miss errors. Features that'd be nice, but can be done with out.

  
Medium Priority

Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount

  
Meta

for all the other fun stuff about the project thats not code

  
needs more info

Something is wrong

  
question

   
refactor

Cleaning up the cruft

  
wontfix

This won't be fixed

  
bug

Something is not working

  
Critical Priority

Absolutely urgent issues that must be delt with before others can even be considered.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
High Priority

Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.

  
invalid

Something is wrong

  
Low Priority

Minor or easy to miss errors. Features that'd be nice, but can be done with out.

  
Medium Priority

Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount

  
Meta

for all the other fun stuff about the project thats not code

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
Critical Priority
duplicate
enhancement
help wanted
High Priority
Low Priority
Medium Priority
Meta
needs more info
question
refactor
wontfix
bug
Critical Priority
duplicate
enhancement
help wanted
High Priority
invalid
Low Priority
Medium Priority
Meta
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Patchy-Patch5 Release
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#29 Fixes #19 - Extras menu
Cavemanon/SnootGame
Reference: Cavemanon/SnootGame#21
No description provided.
Delete Branch "updates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?