Resolves #209 | Simplifies the language selector and adds the notice prompt
#210
Merged
MapAnon
merged 8 commits from GManon/SnootGame:LanSel
into Patch8-RAGE
4 months ago
Reviewers
Request review
No reviewers
Labels
Clear labels
Absolutely urgent issues that must be delt with before others can even be considered.
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
for all the other fun stuff about the project thats not code
Something is not working
This issue or pull request already exists
New feature
Need some help
Something is wrong
Cleaning up the cruft
This won't be fixed
Absolutely urgent issues that must be delt with before others can even be considered.
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
for all the other fun stuff about the project thats not code
Something is not working
This issue or pull request already exists
New feature
Need some help
Something is wrong
More information is needed
This won't be fixed
Apply labels
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
needs more info
Something is wrong
question
refactor
Cleaning up the cruft
wontfix
This won't be fixed
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Critical Priority
High Priority
Low Priority
Medium Priority
Meta
bug
duplicate
enhancement
help wanted
needs more info
question
refactor
wontfix
Critical Priority
High Priority
Low Priority
Medium Priority
Meta
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: Cavemanon/SnootGame#210
Reference in New Issue
There is no content yet.
Delete Branch 'GManon/SnootGame:LanSel'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
This PR changes the language selector from a custom displayable to a screen.
Here's how the initial prompt screen looks like

Here's the preferences screen

How it would look like if (for some reason) there where 200 translations.

And the preferences screen for that scenario.

And finally how the notice looks like (You only see it once per language [But it's not like you can see this screen more than once])

Nicely done.
For better responsiveness, use easein_cubic for the glow transforms.
On the translation screen, clicking ok when the prompt shows up should take you straight to the menu, otherwise it'll seem like you can't select the spanish option at first.
Doesn't seem there is code to have the prompt show up in the options menu as well, so please put that in, otherwise persistent.seenWarning is moot.
Short list of critique:
Implemented everything Map asked for. And both the prompt and the preferences screen now accomodate for weird flags and images with different resolutions, although they do need to be in the same range of resolution (The "Small image" option from wikipedia works nicely).
It's gonna be complicated, but I'll try making the images dim in the preferences screen.
It was easier than what I imagined. Unless there are more issues this should be ready to merge.
No issues so far, seems good to go.
60a1748177
into Patch8-RAGE 4 months ago60a1748177
.Step 1:
From your project repository, check out a new branch and test the changes.Step 2:
Merge the changes and update on Gitea.