Resolves #209 | Simplifies the language selector and adds the notice prompt #210
No reviewers
Labels
No Label
bug
Critical Priority
duplicate
enhancement
help wanted
High Priority
Low Priority
Medium Priority
Meta
needs more info
question
refactor
wontfix
bug
Critical Priority
duplicate
enhancement
help wanted
High Priority
invalid
Low Priority
Medium Priority
Meta
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Cavemanon/SnootGame#210
Loading…
Reference in New Issue
No description provided.
Delete Branch "Legalo/SnootGame:LanSel"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR changes the language selector from a custom displayable to a screen.
Here's how the initial prompt screen looks like
Here's the preferences screen
How it would look like if (for some reason) there where 200 translations.
And the preferences screen for that scenario.
And finally how the notice looks like (You only see it once per language [But it's not like you can see this screen more than once])
Nicely done.
For better responsiveness, use easein_cubic for the glow transforms.
On the translation screen, clicking ok when the prompt shows up should take you straight to the menu, otherwise it'll seem like you can't select the spanish option at first.
Doesn't seem there is code to have the prompt show up in the options menu as well, so please put that in, otherwise persistent.seenWarning is moot.
Short list of critique:
Implemented everything Map asked for. And both the prompt and the preferences screen now accomodate for weird flags and images with different resolutions, although they do need to be in the same range of resolution (The "Small image" option from wikipedia works nicely).
It's gonna be complicated, but I'll try making the images dim in the preferences screen.
It was easier than what I imagined. Unless there are more issues this should be ready to merge.
No issues so far, seems good to go.