Resolves #209 | Simplifies the language selector and adds the notice prompt #210

GManon · 2022-11-28T10:10:11Z

GManon commented

2022-11-28 10:10:11 +00:00

This PR changes the language selector from a custom displayable to a screen.

Here's how the initial prompt screen looks like

Here's the preferences screen

How it would look like if (for some reason) there where 200 translations.

And the preferences screen for that scenario.

And finally how the notice looks like (You only see it once per language [But it's not like you can see this screen more than once])

This PR changes the language selector from a custom displayable to a screen. Here's how the initial prompt screen looks like ![](https://git.snootgame.xyz/attachments/b14e3d3c-87f7-42e6-9a3a-93a81cf6ef29) Here's the preferences screen ![](https://git.snootgame.xyz/attachments/64022813-23bb-46a6-bfed-aa98051e0000) How it would look like if (for some reason) there where 200 translations. ![](https://git.snootgame.xyz/attachments/7d9c586d-0b48-4278-9177-71936da01510) And the preferences screen for that scenario. ![](https://git.snootgame.xyz/attachments/222fc824-717d-4433-9149-40072b65bc8a) And finally how the notice looks like (You only see it once per language \[But it's not like you can see this screen more than once]) ![](https://git.snootgame.xyz/attachments/232e93c2-4725-46a6-ab41-741879e47d74)

screenshot0006.png

580 KiB

screenshot0007.png

409 KiB

screenshot0008.png

572 KiB

screenshot0009.png

303 KiB

screenshot0010.png

459 KiB

GManon added 1 commit 2022-11-28 10:10:17 +00:00

Implements language selector 1b3f5d615a

GManon added 1 commit 2022-11-28 10:19:19 +00:00

Makes both flags the same size 5e8959c5dd

GManon added 1 commit 2022-11-28 10:32:20 +00:00

Makes the beginning prompt prettier eb86298f2c

MapAnon commented

2022-11-28 18:45:02 +00:00

Nicely done.

For better responsiveness, use easein_cubic for the glow transforms.
On the translation screen, clicking ok when the prompt shows up should take you straight to the menu, otherwise it'll seem like you can't select the spanish option at first.
Doesn't seem there is code to have the prompt show up in the options menu as well, so please put that in, otherwise persistent.seenWarning is moot.

Nicely done. For better responsiveness, use easein_cubic for the glow transforms. On the translation screen, clicking ok when the prompt shows up should take you straight to the menu, otherwise it'll seem like you can't select the spanish option at first. Doesn't seem there is code to have the prompt show up in the options menu as well, so please put that in, otherwise persistent.seenWarning is moot.

nutbuster commented

2022-11-28 20:44:20 +00:00

Short list of critique:

The highlighted language can only be glanced by having a purple slip next to it, before it was: the flag and text were both highlighted on the selected language, unselected were dimmed in comparison.
The images aren't scaled / transformed to fit. (important for other flags with ratios of 1:2, etc.)

Short list of critique: - The highlighted language can only be glanced by having a purple slip next to it, before it was: the flag and text were both highlighted on the selected language, unselected were dimmed in comparison. - The images aren't scaled / transformed to fit. (important for other flags with ratios of 1:2, etc.)

GManon added 1 commit 2022-11-28 21:37:13 +00:00

Accommodates for weird flags and long language names fc2096d3f3

GManon added 1 commit 2022-11-28 21:56:21 +00:00

Adds notice prompt to preferences screen 57555453b8

GManon added 1 commit 2022-11-28 22:13:08 +00:00

Actually accommodates for weird flags. For real this time. 9252776dad

GManon commented

2022-11-28 22:17:17 +00:00

Implemented everything Map asked for. And both the prompt and the preferences screen now accomodate for weird flags and images with different resolutions, although they do need to be in the same range of resolution (The "Small image" option from wikipedia works nicely).

It's gonna be complicated, but I'll try making the images dim in the preferences screen.

Implemented everything Map asked for. And both the prompt and the preferences screen now accomodate for weird flags and images with different resolutions, although they do need to be in the same range of resolution (The "Small image" option from wikipedia works nicely). It's gonna be complicated, but I'll try making the images dim in the preferences screen.

screenshot0016.png

579 KiB

screenshot0014.png

413 KiB

GManon added 1 commit 2022-11-28 22:37:45 +00:00

Implements darkie for preferences screen 11ceb1a73f

GManon commented

2022-11-28 22:39:46 +00:00

It was easier than what I imagined. Unless there are more issues this should be ready to merge.

snootvid.mp4

822 KiB

GManon added 1 commit 2022-11-28 22:59:27 +00:00