Resolves #209 | Simplifies the language selector and adds the notice prompt #210

Merged
MapAnon merged 8 commits from GManon/SnootGame:LanSel into Patch8-RAGE 4 months ago

This PR changes the language selector from a custom displayable to a screen.

Here's how the initial prompt screen looks like

Here's the preferences screen

How it would look like if (for some reason) there where 200 translations.

And the preferences screen for that scenario.

And finally how the notice looks like (You only see it once per language [But it's not like you can see this screen more than once])

This PR changes the language selector from a custom displayable to a screen. Here's how the initial prompt screen looks like ![](https://git.snootgame.xyz/attachments/b14e3d3c-87f7-42e6-9a3a-93a81cf6ef29) Here's the preferences screen ![](https://git.snootgame.xyz/attachments/64022813-23bb-46a6-bfed-aa98051e0000) How it would look like if (for some reason) there where 200 translations. ![](https://git.snootgame.xyz/attachments/7d9c586d-0b48-4278-9177-71936da01510) And the preferences screen for that scenario. ![](https://git.snootgame.xyz/attachments/222fc824-717d-4433-9149-40072b65bc8a) And finally how the notice looks like (You only see it once per language \[But it's not like you can see this screen more than once]) ![](https://git.snootgame.xyz/attachments/232e93c2-4725-46a6-ab41-741879e47d74)
Collaborator

Nicely done.

For better responsiveness, use easein_cubic for the glow transforms.
On the translation screen, clicking ok when the prompt shows up should take you straight to the menu, otherwise it'll seem like you can't select the spanish option at first.
Doesn't seem there is code to have the prompt show up in the options menu as well, so please put that in, otherwise persistent.seenWarning is moot.

Nicely done. For better responsiveness, use easein_cubic for the glow transforms. On the translation screen, clicking ok when the prompt shows up should take you straight to the menu, otherwise it'll seem like you can't select the spanish option at first. Doesn't seem there is code to have the prompt show up in the options menu as well, so please put that in, otherwise persistent.seenWarning is moot.
Collaborator

Short list of critique:

  • The highlighted language can only be glanced by having a purple slip next to it, before it was: the flag and text were both highlighted on the selected language, unselected were dimmed in comparison.
  • The images aren't scaled / transformed to fit. (important for other flags with ratios of 1:2, etc.)
Short list of critique: - The highlighted language can only be glanced by having a purple slip next to it, before it was: the flag and text were both highlighted on the selected language, unselected were dimmed in comparison. - The images aren't scaled / transformed to fit. (important for other flags with ratios of 1:2, etc.)
Poster

Implemented everything Map asked for. And both the prompt and the preferences screen now accomodate for weird flags and images with different resolutions, although they do need to be in the same range of resolution (The "Small image" option from wikipedia works nicely).

It's gonna be complicated, but I'll try making the images dim in the preferences screen.

Implemented everything Map asked for. And both the prompt and the preferences screen now accomodate for weird flags and images with different resolutions, although they do need to be in the same range of resolution (The "Small image" option from wikipedia works nicely). It's gonna be complicated, but I'll try making the images dim in the preferences screen.
Poster

It was easier than what I imagined. Unless there are more issues this should be ready to merge.

It was easier than what I imagined. Unless there are more issues this should be ready to merge.
Collaborator

No issues so far, seems good to go.

No issues so far, seems good to go.
MapAnon merged commit 60a1748177 into Patch8-RAGE 4 months ago
The pull request has been merged as 60a1748177.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b GManon-LanSel Patch8-RAGE
git pull LanSel

Step 2:

Merge the changes and update on Gitea.
git checkout Patch8-RAGE
git merge --no-ff GManon-LanSel
git push origin Patch8-RAGE
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Cavemanon/SnootGame#210
Loading…
There is no content yet.