fix: Cleans up TODO regarding duplicate Rosa line. #223

san7890 · 2023-05-07T05:55:18Z

san7890 commented

2023-05-07 05:55:18 +00:00

I decided to go through some of the TODO's and was pleasantly suprised to find that something that had nagged me in my initial playthrough was marked as a TODO item for later.

Please do let me know if this goes against any writing wishes or anything like that, I figured it was okay since it was flagged for later fixing (and later is now). The reason why it's worded like this is because the preceding lines mention that the first flowerbush is comprised of Middlemist Red, which is actually the rarest flower on Earth. I don't know how a high school managed to both grow a flowerbed full of these as well as not have it behind a glass wall or something (dinosaur magic maybe) but I think this fits just as well, while being even more clever to gardening aficionados, without having Rosa parrot the same phrase. The second flowerbush doesn't actually say what flowers it's made of, so that one gets to keep the blooming line.

It's been a while since I've had to write in Spanish, and I'm certainly better at reading it than writing it. I just looked up equivalent phrases and this seems alright enough to me? I don't know who to reach out to for proof-reading the Spanish translation of this game so that would be highly appreciated if they could give it a lookover and tell me if this actually makes sense or if it needs to be altered to better fit Rosa or anything like that.

Thanks for your time.

I decided to go through some of the TODO's and was pleasantly suprised to find that something that had nagged me in my initial playthrough was marked as a TODO item for later. **Please do let me know if this goes against any writing wishes or anything like that**, I figured it was okay since it was flagged for later fixing (and later is now). The reason why it's worded like this is because the preceding lines mention that the _first_ flowerbush is comprised of Middlemist Red, which is actually _the rarest_ flower on Earth. I don't know how a high school managed to both grow a flowerbed full of these as well as not have it behind a glass wall or something (dinosaur magic maybe) but I think this fits just as well, while being even more clever to gardening aficionados, without having Rosa parrot the same phrase. The second flowerbush doesn't actually say what flowers it's made of, so that one gets to keep the blooming line. It's been a while since I've had to write in Spanish, and I'm certainly better at reading it than writing it. I just looked up equivalent phrases and this seems alright enough to me? I don't know who to reach out to for proof-reading the Spanish translation of this game so that would be highly appreciated if they could give it a lookover and tell me if this actually makes sense or if it needs to be altered to better fit Rosa or anything like that. Thanks for your time.

san7890 added 1 commit 2023-05-07 05:55:33 +00:00

93a548957d fix: Cleans up TODO regarding duplicate Rosa line.

Also includes shoddy Spanish translation, definitely requires proofreading.

san7890 changed title from ~~fix: Cleans up TODO regarding duplicate Rosa line.~~ to wip: fix: Cleans up TODO regarding duplicate Rosa line.

2023-05-07 06:08:11 +00:00

MichaelYick requested review from MichaelYick 2023-05-07 06:13:35 +00:00

MichaelYick added the

enhancement

Low Priority

labels 2023-05-07 06:13:46 +00:00

san7890 added 1 commit 2023-05-07 06:27:01 +00:00

279608bf80 actually uses the automated renpy translation feature formatting

didn't use the automated renpy feature so this wasn't correct whoops

san7890 changed title from ~~wip: fix: Cleans up TODO regarding duplicate Rosa line.~~ to fix: Cleans up TODO regarding duplicate Rosa line.

2023-05-07 06:27:02 +00:00

GManon reviewed 2023-05-14 04:19:19 +00:00

game/tl/es/script/5.fang-and-anon-cut-class-to-talk-on-the-roof.rpy

						
				@ -6947,0 +6944,4 @@

				translate es movie_f9188bac:

				    # Ro "I just{cps=*.1}...{/cps}{w=.3} URGH!{w=.4} Do you have {i}any{/i} idea how hard those are to get!"

				    Ro "Solo{cps=*.1}...{/cps}{w=.3} ¡URGH!{w=.4} ¿Tienes {i}alguna{/i} idea de lo dificil que son para conseguierlos?"

GManon commented

2023-05-14 04:19:19 +00:00

¿Tienes {i}alguna{/i} idea de lo difícil que son conseguirlas?

MichaelYick approved these changes 2023-06-29 01:56:56 +00:00

MichaelYick left a comment

looks fine to me, likely will need to talk to writers though.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b san7890-hunting NewPatch

git pull hunting

Step 2:

Merge the changes and update on Gitea.

git checkout NewPatch

git merge --no-ff san7890-hunting

git push origin NewPatch

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Cavemanon/SnootGame#223