Cavemanon/SnootGame
25
Fork 18
Code Issues 4 Pull Requests 1 Actions Projects Releases 10 Wiki Activity

fix: Cleans up TODO regarding duplicate Rosa line. #223

Closed
san7890 wants to merge 2 commits from san7890/SnootGame:hunting into NewPatch
pull from: san7890/SnootGame:hunting
merge into: Cavemanon:NewPatch
Conversation 3 Commits 2 Files Changed 2 +9 -8
san7890 commented 2023-05-07 05:55:18 +00:00
Contributor
Copy Link

I decided to go through some of the TODO's and was pleasantly suprised to find that something that had nagged me in my initial playthrough was marked as a TODO item for later.

Please do let me know if this goes against any writing wishes or anything like that, I figured it was okay since it was flagged for later fixing (and later is now). The reason why it's worded like this is because the preceding lines mention that the first flowerbush is comprised of Middlemist Red, which is actually the rarest flower on Earth. I don't know how a high school managed to both grow a flowerbed full of these as well as not have it behind a glass wall or something (dinosaur magic maybe) but I think this fits just as well, while being even more clever to gardening aficionados, without having Rosa parrot the same phrase. The second flowerbush doesn't actually say what flowers it's made of, so that one gets to keep the blooming line.

It's been a while since I've had to write in Spanish, and I'm certainly better at reading it than writing it. I just looked up equivalent phrases and this seems alright enough to me? I don't know who to reach out to for proof-reading the Spanish translation of this game so that would be highly appreciated if they could give it a lookover and tell me if this actually makes sense or if it needs to be altered to better fit Rosa or anything like that.

Thanks for your time.

I decided to go through some of the TODO's and was pleasantly suprised to find that something that had nagged me in my initial playthrough was marked as a TODO item for later. **Please do let me know if this goes against any writing wishes or anything like that**, I figured it was okay since it was flagged for later fixing (and later is now). The reason why it's worded like this is because the preceding lines mention that the _first_ flowerbush is comprised of Middlemist Red, which is actually _the rarest_ flower on Earth. I don't know how a high school managed to both grow a flowerbed full of these as well as not have it behind a glass wall or something (dinosaur magic maybe) but I think this fits just as well, while being even more clever to gardening aficionados, without having Rosa parrot the same phrase. The second flowerbush doesn't actually say what flowers it's made of, so that one gets to keep the blooming line. It's been a while since I've had to write in Spanish, and I'm certainly better at reading it than writing it. I just looked up equivalent phrases and this seems alright enough to me? I don't know who to reach out to for proof-reading the Spanish translation of this game so that would be highly appreciated if they could give it a lookover and tell me if this actually makes sense or if it needs to be altered to better fit Rosa or anything like that. Thanks for your time.
san7890 added 1 commit 2023-05-07 05:55:33 +00:00
fix: Cleans up TODO regarding duplicate Rosa line. 93a548957d 
Also includes shoddy Spanish translation, definitely requires proofreading.
san7890 changed title from fix: Cleans up TODO regarding duplicate Rosa line. to wip: fix: Cleans up TODO regarding duplicate Rosa line. 2023-05-07 06:08:11 +00:00
MichaelYick requested review from MichaelYick 2023-05-07 06:13:35 +00:00
MichaelYick added the
enhancement
Low Priority
 labels 2023-05-07 06:13:46 +00:00
san7890 added 1 commit 2023-05-07 06:27:01 +00:00
actually uses the automated renpy translation feature formatting 279608bf80 
didn't use the automated renpy feature so this wasn't correct whoops
san7890 changed title from wip: fix: Cleans up TODO regarding duplicate Rosa line. to fix: Cleans up TODO regarding duplicate Rosa line. 2023-05-07 06:27:02 +00:00
GManon reviewed 2023-05-14 04:19:19 +00:00
game/tl/es/script/5.fang-and-anon-cut-class-to-talk-on-the-roof.rpy
@ -6947,0 +6944,4 @@
translate es movie_f9188bac:
# Ro "I just{cps=*.1}...{/cps}{w=.3} URGH!{w=.4} Do you have {i}any{/i} idea how hard those are to get!"
Ro "Solo{cps=*.1}...{/cps}{w=.3} ¡URGH!{w=.4} ¿Tienes {i}alguna{/i} idea de lo dificil que son para conseguierlos?"
GManon commented 2023-05-14 04:19:19 +00:00
Contributor
Copy Link

¿Tienes {i}alguna{/i} idea de lo difícil que son conseguirlas?

¿Tienes {i}alguna{/i} idea de lo difícil que son conseguirlas?
MichaelYick approved these changes 2023-06-29 01:56:56 +00:00
MichaelYick left a comment
Owner
Copy Link

looks fine to me, likely will need to talk to writers though.

looks fine to me, likely will need to talk to writers though.
MapAnon commented 2024-06-13 08:14:41 +00:00
Member
Copy Link

This has been merged manually, including the suggested spanish line and tweaks to make it work with other languages.

This has been merged manually, including the suggested spanish line and tweaks to make it work with other languages.
MapAnon closed this pull request 2024-06-13 08:14:41 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
MichaelYick
Labels
Clear labels
bug
Something is not working
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
needs more info
Something is wrong
question
refactor
Cleaning up the cruft
wontfix
This won't be fixed
bug
Something is not working
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
invalid
Something is wrong
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Low Priority
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Cereal Jatmoz Jingo Jluminate Legalo Map MapAnon MichaelYick Mod Nerd Nio nutbuster ReleaseSmith Sl1 TheNerd writerdev
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Cavemanon/SnootGame#223
No description provided.
Delete Branch "san7890/SnootGame:hunting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?