Template Managment complete #27

t_a · 2023-05-17T16:46:49Z

t_a commented

2023-05-17 16:46:49 +00:00

regarding bbf526f99f I am unsure if i am satisfied with this so i might go back to later and force a reentry with a proper name, tho fundamentally i don't think there is an issue with this solution.

regarding bbf526f99febd4b6e3cfc70242205791e63f15e4 I am unsure if i am satisfied with this so i might go back to later and force a reentry with a proper name, tho fundamentally i don't think there is an issue with this solution.

t_a added 5 commits 2023-05-17 16:47:05 +00:00

09406b0852 Template for managment of templates + add button for creation of new template

383db248b7 Create new Template

+minor refactoring

bbf526f99f minor fix to avoid the creation of '' templates since crow is incapable of routing those to /<string> while trying to route them to / leading to a 404

obviously it's also possible to just give a general you have to name your template directive but as it stands i don't really see a need for it

d9f3fd711c implement base template operations with the corresponding templates

fully implement the delete operation
todo:edit operation

1620967c45 implementation of the edit function for the template managment

+minor typo fixes

t_a added 3 commits 2023-05-19 16:11:29 +00:00

d83b427857 implement freelancer alias base management page

and minor fixes

bfddfd5271 implement freelancer alias deletion

549c98f673 implement freelancer alias creation

MichaelYick requested changes 2023-05-19 17:24:36 +00:00

src/main.cpp Outdated

						
				@ -659,0 +676,4 @@

				                crow::mustache::context ctx;

				                if (Utilities::checkCookieLoginState(configuration, cookieCtx)) {

				                    ctx[MUSTACHE_COOKIE_LOGGED_IN] = true;

				                    string name, content, contactdata, contactinformation, currencypreference, priceupfront, priceondeliver;

MichaelYick commented

2023-05-19 17:20:48 +00:00

From what I'm seeing, these strings are all associated with each other, and may be better off held in a struct. This might make some of the later lines with all the splitItem.at() comparisons a bit easier to deal with.

t_a commented

2023-05-22 14:27:40 +00:00

Yeah a struct in this case is quite a good idea

👍 1

src/main.cpp

						
				@ -659,0 +697,4 @@

				                        if (splitItem.at(0) == "templatepriceupfront")

				                            priceupfront = splitItem.at(1);

				                        if (splitItem.at(0) == "templatepriceondeliver")

				                            priceondeliver = splitItem.at(1);

MichaelYick commented

2023-05-19 17:16:57 +00:00

could save splitItem.at(0)'s as a variable, then just use a switch statement to cut down on the amount of times splitItem.at() is called.

t_a commented

2023-05-22 14:32:59 +00:00

True, i am kinda pointlessly using at(), [] would have been more appropriate since it directly access the data, maybe i am misunderstanding something but in c++ switch is not capable of evaluating strings and would require an intermediate step that would introduce unnecessary operations.

And i believe saving splitItem.at(0) as a variable would be unnecessary both due to memory and operations, since splitItem[0] should achieve the same thing without the unnecessary performance loss that at() incurs.

True, i am kinda pointlessly using at(), [] would have been more appropriate since it directly access the data, maybe i am misunderstanding something but in c++ switch is not capable of evaluating strings and would require an intermediate step that would introduce unnecessary operations. And i believe saving splitItem.at(0) as a variable would be unnecessary both due to memory and operations, since splitItem[0] should achieve the same thing without the unnecessary performance loss that at() incurs.

👍 1

src/main.cpp Outdated

						
				@ -698,0 +825,4 @@

				                                    priceupfront = splitItem.at(1);

				                                if (splitItem.at(0) == "templatepriceondeliver")

				                                    priceondeliver = splitItem.at(1);

				                            }

MichaelYick commented

2023-05-19 17:19:41 +00:00

could save splitItem.at(0)'s as a variable, then just use a switch statement to cut down on the amount of times splitItem.at() is called.

Given that pattern has appeared twice, it may be a good idea to just make a function for this. However, this advise is conditional on if it would be easy to do that or not.

could save splitItem.at(0)'s as a variable, then just use a switch statement to cut down on the amount of times splitItem.at() is called. Given that pattern has appeared twice, it may be a good idea to just make a function for this. However, this advise is conditional on if it would be easy to do that or not.

t_a commented

2023-05-22 14:34:19 +00:00

I will be moving it into a separate function partially to minimize the duplication of the parser and partially due to the duplication of hardcoded strings

👍 1

t_a added 1 commit 2023-05-22 15:05:49 +00:00

9e5f0a68ab Optimize template edit/creation requestbody parsing

t_a commented

2023-05-22 15:07:58 +00:00

the commit 9e5f0a68ab should address it

the commit 9e5f0a68ab should address it

MichaelYick approved these changes 2023-05-23 01:46:31 +00:00

MichaelYick merged commit 04dc38a944 into master

2023-05-23 01:46:53 +00:00

MichaelYick referenced this issue from a commit

2023-05-23 01:47:00 +00:00