Cavemanon/cavemanon-wagtail-personalisation
Archived
7
Fork 0
Code Issues Pull Requests Activity

Allow test_user() for static rules to accept a user

Browse Source
This commit is contained in:
Kaitlyn Crawford
2018-01-24 15:14:24 +02:00
parent 6299feb497
commit 33f96af4a3
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/wagtail_personalisation/rules.py
View File

@ -220,7 +220,12 @@ class VisitCountRule(AbstractBaseRule):
class Meta: class Meta:
verbose_name = _('Visit count Rule') verbose_name = _('Visit count Rule')
def test_user(self, request): def test_user(self, request, user=None):
if user:
# This rule currently does not support testing a user directly
# TODO: Make this test a user directly when the rule uses
# historical data
return False
operator = self.operator operator = self.operator
segment_count = self.count segment_count = self.count
@ -276,7 +281,13 @@ class QueryRule(AbstractBaseRule):
class Meta: class Meta:
verbose_name = _('Query Rule') verbose_name = _('Query Rule')
def test_user(self, request): def test_user(self, request, user=None):
if user:
# This rule currently does not support testing a user directly
# TODO: Make this test a user directly if/when the rule uses
# historical data
return False
return request.GET.get(self.parameter, '') == self.value return request.GET.get(self.parameter, '') == self.value
def description(self): def description(self):