diff --git a/src/wagtail_personalisation/rules.py b/src/wagtail_personalisation/rules.py index f4e6fa7..5316002 100644 --- a/src/wagtail_personalisation/rules.py +++ b/src/wagtail_personalisation/rules.py @@ -266,7 +266,6 @@ class QueryRule(AbstractBaseRule): """ icon = 'fa-link' - static = True parameter = models.SlugField(_("The query parameter to search for"), max_length=20) @@ -281,13 +280,7 @@ class QueryRule(AbstractBaseRule): class Meta: verbose_name = _('Query Rule') - def test_user(self, request, user=None): - if user: - # This rule currently does not support testing a user directly - # TODO: Make this test a user directly if/when the rule uses - # historical data - return False - + def test_user(self, request): return request.GET.get(self.parameter, '') == self.value def description(self): diff --git a/tests/unit/test_factories.py b/tests/unit/test_factories.py index dc2402c..0ce5b7c 100644 --- a/tests/unit/test_factories.py +++ b/tests/unit/test_factories.py @@ -45,4 +45,3 @@ def test_query_rule_create(): assert query_rule.parameter == 'query' assert query_rule.value == 'value' - assert query_rule.static