diff --git a/CHANGES b/CHANGES index a9a971a..de2c3bf 100644 --- a/CHANGES +++ b/CHANGES @@ -1,6 +1,6 @@ 0.13.0 ================= - - Merged Praekolt fork + - Merged Praekelt fork - Add custom javascript to segment forms - bugfix:exclude variant returns queryset when params is queryset - Added RulePanel, a subclass of InlinePanel, for Rules @@ -12,7 +12,7 @@ 0.12.0 ================== - - Merged forks of Torchbox and Praekolt + - Merged forks of Torchbox and Praekelt - Wagtail 2 compatibility - Makefile adjustments for portability - Adds simple segment forcing for superusers diff --git a/src/wagtail_personalisation/models.py b/src/wagtail_personalisation/models.py index 1e167f4..1b28dd4 100644 --- a/src/wagtail_personalisation/models.py +++ b/src/wagtail_personalisation/models.py @@ -22,8 +22,8 @@ from .forms import SegmentAdminForm class RulePanel(InlinePanel): def on_model_bound(self): - self.db_field = self.model._meta.get_field( - self.relation_name.replace('_related', 's')) + self.relation_name = self.relation_name.replace('_related', 's') + self.db_field = self.model._meta.get_field(self.relation_name) manager = getattr(self.model, self.relation_name) self.related = manager.rel diff --git a/tests/settings.py b/tests/settings.py index 1c2d0ee..b02ff71 100644 --- a/tests/settings.py +++ b/tests/settings.py @@ -1,7 +1,4 @@ import os -from distutils.version import StrictVersion as V - -import django DATABASES = { 'default': { @@ -54,26 +51,16 @@ TEMPLATES = [ ] -def get_middleware_settings(): - return ( - 'django.middleware.common.CommonMiddleware', - 'django.contrib.sessions.middleware.SessionMiddleware', - 'django.middleware.csrf.CsrfViewMiddleware', - 'django.contrib.auth.middleware.AuthenticationMiddleware', - 'django.contrib.auth.middleware.SessionAuthenticationMiddleware', - 'django.contrib.messages.middleware.MessageMiddleware', - 'django.middleware.clickjacking.XFrameOptionsMiddleware', - - 'wagtail.core.middleware.SiteMiddleware', - ) - - -# Django 1.10 started to use "MIDDLEWARE" instead of "MIDDLEWARE_CLASSES". -if V(django.get_version()) < V('1.10'): - MIDDLEWARE_CLASSES = get_middleware_settings() -else: - MIDDLEWARE = get_middleware_settings() +MIDDLEWARE = ( + 'django.middleware.common.CommonMiddleware', + 'django.contrib.sessions.middleware.SessionMiddleware', + 'django.middleware.csrf.CsrfViewMiddleware', + 'django.contrib.auth.middleware.AuthenticationMiddleware', + 'django.contrib.messages.middleware.MessageMiddleware', + 'django.middleware.clickjacking.XFrameOptionsMiddleware', + 'wagtail.core.middleware.SiteMiddleware', +) INSTALLED_APPS = ( 'wagtail_personalisation', diff --git a/tests/unit/test_models.py b/tests/unit/test_models.py index 0a7cd27..df2d5f0 100644 --- a/tests/unit/test_models.py +++ b/tests/unit/test_models.py @@ -75,6 +75,6 @@ def test_sitemap_generation_for_variants_is_disabled(segmented_page): @pytest.mark.django_db def test_segment_edit_view(site, client, django_user_model): - test_segment = Segment() + test_segment = SegmentFactory() new_panel = test_segment.panels[1].children[0].bind_to_model(Segment) assert new_panel.related.name == "wagtail_personalisation_timerules"