Cavemanon/cavemanon-wagtail-personalisation
Archived
7
Fork 0
Code Issues Pull Requests Activity

Fixes persistent rule persisting

Browse Source
This commit is contained in:
Jasper Berghoef
2017-05-24 21:21:24 +02:00
parent 974a4d6f46
commit 5f1c52c93c
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/personalisation/adapters.py
View File

@ -144,10 +144,10 @@ class SessionSegmentsAdapter(BaseSegmentsAdapter):
session_segments = self.request.session['segments'] session_segments = self.request.session['segments']
rules = AbstractBaseRule.__subclasses__() rules = AbstractBaseRule.__subclasses__()
# Create a list to store the new requet session segments and # Create a list to store the new request session segments and
# re-apply all persistent segments. # re-apply all persistent segments (if they are still enabled).
new_segments = [segment for segment in session_segments new_segments = [segment for segment in session_segments
if segment in persistent_segments] if persistent_segments.filter(id=segment['id']).exists()]
# Run tests on all remaining enabled segments to verify applicability. # Run tests on all remaining enabled segments to verify applicability.
for segment in enabled_segments: for segment in enabled_segments:

1
tests/unit/test_middleware.py
View File

@ -218,7 +218,6 @@ class TestUserSegmenting(object):
assert any(item['encoded_name'] == 'multiple-queries' for item in client.session['segments']) assert any(item['encoded_name'] == 'multiple-queries' for item in client.session['segments'])
@pytest.mark.skip
def test_persistent_segmenting(self, client): def test_persistent_segmenting(self, client):
segment = SegmentFactory(name='Persistent', persistent=True) segment = SegmentFactory(name='Persistent', persistent=True)
query_rule = QueryRuleFactory( query_rule = QueryRuleFactory(