From aafc8c4ed5ddda9c3e9c80412a83d82b5e96c0fb Mon Sep 17 00:00:00 2001 From: Jasper Berghoef Date: Fri, 2 Jun 2017 15:06:53 +0200 Subject: [PATCH] Simpler queries --- src/wagtail_personalisation/models.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/wagtail_personalisation/models.py b/src/wagtail_personalisation/models.py index c32730a..9d6eb1b 100644 --- a/src/wagtail_personalisation/models.py +++ b/src/wagtail_personalisation/models.py @@ -81,17 +81,15 @@ class Segment(ClusterableModel): def get_used_pages(self): """Return the pages that have variants using this segment.""" - pages = [page for page - in PersonalisablePageMetadata.objects.filter(segment=self)] + pages = list(PersonalisablePageMetadata.objects.filter(segment=self)) return pages def get_created_variants(self): """Return the variants using this segment.""" - pages = [page.variations for page - in PersonalisablePageMetadata.objects.filter(segment=self)] + pages = Page.objects.filter(_personalisable_page_metadata__segment=self) - return list(itertools.chain(*pages)) + return pages def get_rules(self): """Retrieve all rules in the segment."""