make order querylets a first class citizen instead of a hack

2020-10-25 12:55:13 +00:00
parent 19d5cfe8b9
commit 0dca09c230
4 changed files with 25 additions and 33 deletions
--- a/ext/numeric_score/main.php
+++ b/ext/numeric_score/main.php
@ -272,8 +272,7 @@ class NumericScore extends Extension
        } elseif (preg_match("/^order[=|:](?:numeric_)?(score)(?:_(desc|asc))?$/i", $event->term, $matches)) {
            $default_order_for_column = "DESC";
            $sort = isset($matches[2]) ? strtoupper($matches[2]) : $default_order_for_column;
-            Image::$order_sql = "images.numeric_score $sort";
-            $event->add_querylet(new Querylet("1=1")); //small hack to avoid metatag being treated as normal tag
+            $event->order = "images.numeric_score $sort";
        }
    }