Cavemanon/cavepaintings
8
Fork 2
Code Issues 3 Pull Requests Projects Releases Wiki Activity

[core] a load more type hints, and fix bugs revealed by type hints

Browse Source
This commit is contained in:
Shish
2024-01-20 14:10:59 +00:00
parent 373be4e05c
commit b60c3fe362
158 changed files with 1532 additions and 616 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
ext/numeric_score/main.php
View File

@@ -33,8 +33,8 @@ class NumericScoreVote
public static function score(Image $post): int
{
global $database;
if ($post->score ?? null) {
return $post->score;
if ($post['score'] ?? null) {
return $post['score'];
}
return $database->get_one(
"SELECT sum(score) FROM numeric_score_votes WHERE image_id=:image_id",
@@ -42,6 +42,9 @@ class NumericScoreVote
) ?? 0;
}
/**
* @return NumericScoreVote[]
*/
#[Field(extends: "Post", type: "[NumericScoreVote!]!")]
public static function votes(Image $post): array
{
@@ -253,7 +256,7 @@ class NumericScore extends Extension
$this->delete_votes_by($event->id);
}
public function delete_votes_by(int $user_id)
public function delete_votes_by(int $user_id): void
{
global $database;
@@ -405,7 +408,7 @@ class NumericScore extends Extension
}
}
private function add_vote(int $image_id, int $user_id, int $score)
private function add_vote(int $image_id, int $user_id, int $score): void
{
global $database;
$database->execute(