Cavemanon/cavepaintings
7
Fork 2
Code Issues 3 Pull Requests Projects Releases Wiki Activity

Have get_arg never return null

Browse Source 
90% of places assume it will never return null, and they will break in
weird ways if it does return null
This commit is contained in:
Shish
2019-11-04 00:40:10 +00:00
parent fc7da5114f
commit d17e207984
19 changed files with 141 additions and 137 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ext/shimmie_api/main.php
View File

@ -39,10 +39,15 @@ class ShimmieApi extends Extension
$page->set_type("text/plain");
if ($event->page_matches("api/shimmie/get_tags")) {
$tag = $event->get_arg(0);
if (empty($tag) && isset($_GET['tag'])) {
if($event->count_args() > 0) {
$tag = $event->get_arg(0);
}
elseif (isset($_GET['tag'])) {
$tag = $_GET['tag'];
}
else {
$tag = null;
}
$res = $this->api_get_tags($tag);
$page->set_data(json_encode($res));
} elseif ($event->page_matches("api/shimmie/get_image")) {