Commit Graph

1504 Commits

Author SHA1 Message Date
1ca3865a1c Removing the closing PHP "?>" tag as per style guidelines. (Also see: https://stackoverflow.com/questions/4410704/why-would-one-omit-the-close-tag ) 2014-04-25 22:54:51 -04:00
3e899710d7 Stop scrutinizer from complaining here. 2014-04-25 17:40:42 -04:00
c85630198f These variables where never defined depending on the execution path. 2014-04-25 17:40:14 -04:00
6f685ca227 Use the method from core/util to parse the bool from the DB instead. 2014-04-25 17:39:46 -04:00
3a1197256a Need to pull in the global $page variable for this method. 2014-04-25 17:39:06 -04:00
1e15c5e47a Explicitly declare this class variable 2014-04-25 17:38:25 -04:00
bcd3f991de Removing the closing PHP "?>" tag as per style guidelines. 2014-04-25 17:34:20 -04:00
b4e6c0b743 Explicitly check if we can actually find the image by Id. 2014-04-25 16:08:00 -04:00
478eb3a4cc Linting: Check for null return value, and throw an exception if null. 2014-04-25 15:39:00 -04:00
7ef68b15f9 Fix indentation. 2014-04-25 15:38:15 -04:00
b241390fa4 Removing the closing PHP "?>" tag as per style guidelines. 2014-04-24 22:34:45 -04:00
50686ac61e More linting, fix PHPDoc style. 2014-04-24 22:29:29 -04:00
daee99c1bc Removing the closing PHP "?>" tag as per style guidelines. 2014-04-24 22:28:53 -04:00
860af25550 Need to pull in the global $user variable. 2014-04-24 22:22:45 -04:00
4ec5a7ce52 Removing the closing PHP "?>" tag as per style guidelines. 2014-04-24 22:22:16 -04:00
780d5f8709 More linting. Explicitly declare these class variables, as well as comment out dead code. 2014-04-24 22:13:00 -04:00
6e4ae229ef Explicitly declare this class variable 2014-04-24 19:13:41 -04:00
4cc31df737 Update the comments to PHPDoc style guidelines. 2014-04-24 19:02:43 -04:00
ab3f9850e4 Removing the closing PHP "?>" tag as per style guidelines. 2014-04-24 19:01:47 -04:00
709366b70c Explicitly declare these class variables. 2014-04-24 18:44:46 -04:00
7b90331f02 Add missing semi-colon. 2014-04-24 16:56:04 -04:00
e2f5c7a6ec Check for null, just in case. 2014-04-24 05:09:38 -04:00
332c8538b7 Change the function syntax to quiet JSHint. 2014-04-24 04:46:23 -04:00
506e699f8a Not sure if we really need the triple equals. 2014-04-24 01:15:30 -04:00
866d39a68e The 'tags' box actually has a different ID. 2014-04-24 01:15:03 -04:00
51c145d5c9 Some more linting on the bookmarklet.js file. 2014-04-24 01:08:47 -04:00
4b90faf89d Even more linting of JS files. 2014-04-24 00:55:14 -04:00
a105090039 Some more JS linting. 2014-04-23 23:39:09 -04:00
887f963e17 Add the jshint comment to alter how scrutinzer-ci deals with the js. 2014-04-23 23:38:53 -04:00
b775c007cd Give these HTML headers some slight priority over the default value of 50. 2014-04-23 23:07:10 -04:00
a0ab3864c0 Push the headers for the chatbox even further down to make sure that jQuery is already loaded. 2014-04-23 23:01:51 -04:00
8cdf919827 More linting. This time of the JavaScript for the chat-box extension. 2014-04-23 22:43:42 -04:00
0bd031a269 Merge branch 'develop' of github.com:jgen/shimmie2 into linting
Manually resolved conflicts:
	ext/chatbox/js/yshout.js
2014-04-23 22:42:30 -04:00
21e1359b86 Avoid short open tag for PHP. 2014-04-20 05:07:26 -04:00
60980c8839 One more jQuery reference. 2014-04-20 05:04:45 -04:00
a7ba0f887b Again, the chatbox needs help from the jQuery migrate plugin. 2014-04-20 05:00:59 -04:00
2df54b911a Don't use short open tags for PHP as they are not turned on by default in production environments. 2014-04-20 05:00:34 -04:00
e2516fa5cf Chatbox should be fixed now.
The chatbox extension actually needs some functionality that was removed from jQuery versions 1.9 and up. When Shimmie's version of jQuery was bumped up to 1.11 this actually broke the chatbox.
2014-04-20 04:51:19 -04:00
880840623a Need to ensure that this html header is added last. 2014-04-20 04:36:25 -04:00
717401ccab Removing this as jQuery is already included in Shimmie now. 2014-04-20 04:35:33 -04:00
8b698e1b6f Revert this commit. 2014-04-20 04:29:11 -04:00
54362a49c6 Fix the broken chatbox issue. 2014-04-20 04:25:08 -04:00
57a390eaab Massive linting! 2014-04-19 23:38:42 -04:00
dc6653d3be Merge pull request #407 from jgen/hotfix/downtime_theme_edits
Hotfix/downtime theme edits
2014-04-20 00:30:57 +01:00
75c3d8e453 Merge pull request #409 from jgen/linting
Linting
2014-04-20 00:29:53 +01:00
c527ae91d6 More linting and cleanup. 2014-04-19 04:17:28 -04:00
be385deaab Clean up this js file as well. 2014-04-19 02:58:36 -04:00
28d83fda0d Even more linting and cleaning. 2014-04-19 02:33:34 -04:00
2da8c19a07 More linting! 2014-04-19 01:36:18 -04:00
bdf49b33cb Some more linting thanks to scrutinizer-ci 2014-04-19 01:18:49 -04:00