Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix tests

Browse Source 
[MAILPOET-2340]
This commit is contained in:
Amine Ben hammou
2019-09-19 20:55:25 +01:00
committed by Jack Kitterhing
parent e588ebcee9
commit 02683ee87b
2 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/integration/Router/Endpoints/TrackTest.php
View File

@@ -53,7 +53,7 @@ class TrackTest extends \MailPoetTest {
'preview' => false, 'preview' => false,
]; ];
// instantiate class // instantiate class
$this->track = new Track(new Clicks(new SettingsController(), new Cookies()), new Opens()); $this->track = new Track(new Clicks(new SettingsController(), new Cookies()), new Opens(), new LinkTokens());
} }
function testItReturnsFalseWhenTrackDataIsMissing() { function testItReturnsFalseWhenTrackDataIsMissing() {
@@ -81,9 +81,12 @@ class TrackTest extends \MailPoetTest {
] ]
); );
$data->subscriber->email = 'random@email.com'; $data->subscriber->email = 'random@email.com';
$track = Stub::make(Track::class, ['terminate' => function($code) { $track = Stub::make(Track::class, [
expect($code)->equals(403); 'link_tokens' => new LinkTokens,
}]); 'terminate' => function($code) {
expect($code)->equals(403);
},
]);
$track->_validateTrackData($data); $track->_validateTrackData($data);
} }

10
tests/integration/Router/Endpoints/ViewInBrowserTest.php
View File

@@ -44,7 +44,7 @@ class ViewInBrowserTest extends \MailPoetTest {
'preview' => false, 'preview' => false,
]; ];
// instantiate class // instantiate class
$this->view_in_browser = new ViewInBrowser(new AccessControl(new Functions()), new SettingsController()); $this->view_in_browser = new ViewInBrowser(new AccessControl(new Functions()), new SettingsController(), new LinkTokens());
} }
function testItAbortsWhenBrowserPreviewDataIsMissing() { function testItAbortsWhenBrowserPreviewDataIsMissing() {
@@ -63,6 +63,7 @@ class ViewInBrowserTest extends \MailPoetTest {
function testItAbortsWhenBrowserPreviewDataIsInvalid() { function testItAbortsWhenBrowserPreviewDataIsInvalid() {
$view_in_browser = Stub::make($this->view_in_browser, [ $view_in_browser = Stub::make($this->view_in_browser, [
'link_tokens' => new LinkTokens,
'_abort' => Expected::exactly(3), '_abort' => Expected::exactly(3),
], $this); ], $this);
// newsletter ID is invalid // newsletter ID is invalid
@@ -153,12 +154,12 @@ class ViewInBrowserTest extends \MailPoetTest {
$wp_user = wp_set_current_user(0); $wp_user = wp_set_current_user(0);
// when WP user does not have 'manage options' permission, false should be returned // when WP user does not have 'manage options' permission, false should be returned
$wp_user->remove_role('administrator'); $wp_user->remove_role('administrator');
$view_in_browser = new ViewInBrowser(new AccessControl(new Functions()), new SettingsController()); $view_in_browser = new ViewInBrowser(new AccessControl(new Functions()), new SettingsController(), new LinkTokens());
expect($view_in_browser->_validateBrowserPreviewData($data))->false(); expect($view_in_browser->_validateBrowserPreviewData($data))->false();
// when WP has 'manage options' permission, data should be returned // when WP has 'manage options' permission, data should be returned
$wp_user->add_role('administrator'); $wp_user->add_role('administrator');
$view_in_browser = new ViewInBrowser(new AccessControl(new Functions()), new SettingsController()); $view_in_browser = new ViewInBrowser(new AccessControl(new Functions()), new SettingsController(), new LinkTokens());
expect($view_in_browser->_validateBrowserPreviewData($data))->equals($data); expect($view_in_browser->_validateBrowserPreviewData($data))->equals($data);
} }
@@ -174,7 +175,7 @@ class ViewInBrowserTest extends \MailPoetTest {
); );
$data->preview = true; $data->preview = true;
wp_set_current_user(1); wp_set_current_user(1);
$view_in_browser = new ViewInBrowser(new AccessControl(new Functions()), new SettingsController()); $view_in_browser = new ViewInBrowser(new AccessControl(new Functions()), new SettingsController(), new LinkTokens(), new LinkTokens());
$result = $view_in_browser->_validateBrowserPreviewData($data); $result = $view_in_browser->_validateBrowserPreviewData($data);
expect($result->subscriber->id)->equals(1); expect($result->subscriber->id)->equals(1);
} }
@@ -207,6 +208,7 @@ class ViewInBrowserTest extends \MailPoetTest {
function testItReturnsViewActionResult() { function testItReturnsViewActionResult() {
$view_in_browser = Stub::make($this->view_in_browser, [ $view_in_browser = Stub::make($this->view_in_browser, [
'link_tokens' => new LinkTokens,
'_displayNewsletter' => Expected::exactly(1), '_displayNewsletter' => Expected::exactly(1),
'settings' => new SettingsController(), 'settings' => new SettingsController(),
], $this); ], $this);