Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix PHPStan parameter type error introduced after update to version 0.12.83

Browse Source 
This commit fixes the following PHPStan errors introduced after the update to version 0.12.83:

```
 ------ ----------------------------------------------------------------------
  Line   lib/Newsletter/Renderer/Blocks/Footer.php
 ------ ----------------------------------------------------------------------
  18     Parameter #1 $html of method MailPoet\Util\pQuery\pQuery::parseStr()
         expects string, array|string|null given.
 ------ ----------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   lib/Newsletter/Renderer/Blocks/Header.php
 ------ ----------------------------------------------------------------------
  18     Parameter #1 $html of method MailPoet\Util\pQuery\pQuery::parseStr()
         expects string, array|string|null given.
 ------ ----------------------------------------------------------------------
```

[MAILPOET-3491]
This commit is contained in:
Rodrigo Primo
2021-04-06 15:23:56 -03:00
committed by Veljko V
parent 90526362cc
commit 030bd8c1c8
4 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Newsletter/Renderer/Blocks/Footer.php
View File

@ -14,6 +14,9 @@ class Footer {
$lineHeight = sprintf( $lineHeight = sprintf(
'%spx', StylesHelper::$defaultLineHeight * (int)$element['styles']['text']['fontSize'] '%spx', StylesHelper::$defaultLineHeight * (int)$element['styles']['text']['fontSize']
); );
if (!is_string($element['text'])) {
throw new \RuntimeException('$element[\'text\'] should be a string.');
}
$dOMParser = new pQuery(); $dOMParser = new pQuery();
$DOM = $dOMParser->parseStr($element['text']); $DOM = $dOMParser->parseStr($element['text']);
if (isset($element['styles']['link'])) { if (isset($element['styles']['link'])) {

3
lib/Newsletter/Renderer/Blocks/Header.php
View File

@ -14,6 +14,9 @@ class Header {
$lineHeight = sprintf( $lineHeight = sprintf(
'%spx', StylesHelper::$defaultLineHeight * (int)$element['styles']['text']['fontSize'] '%spx', StylesHelper::$defaultLineHeight * (int)$element['styles']['text']['fontSize']
); );
if (!is_string($element['text'])) {
throw new \RuntimeException('$element[\'text\'] should be a string.');
}
$dOMParser = new pQuery(); $dOMParser = new pQuery();
$DOM = $dOMParser->parseStr($element['text']); $DOM = $dOMParser->parseStr($element['text']);
if (isset($element['styles']['link'])) { if (isset($element['styles']['link'])) {

6
tests/unit/Newsletter/Renderer/Blocks/FooterTest.php
View File

@ -52,4 +52,10 @@ class FooterTest extends \MailPoetUnitTest {
$output = (new Footer)->render($this->block); $output = (new Footer)->render($this->block);
expect($output)->stringContainsString('<a href="http://example.com" style="color:#aaaaaa;text-decoration:none">link</a>'); expect($output)->stringContainsString('<a href="http://example.com" style="color:#aaaaaa;text-decoration:none">link</a>');
} }
public function testItRaisesExceptionIfTextIsNotString() {
$this->block['text'] = ['some', 'array'];
$this->expectException('RuntimeException');
(new Footer)->render($this->block);
}
} }

6
tests/unit/Newsletter/Renderer/Blocks/HeaderTest.php
View File

@ -52,4 +52,10 @@ class HeaderTest extends \MailPoetUnitTest {
$output = (new Footer)->render($this->block); $output = (new Footer)->render($this->block);
expect($output)->stringContainsString('<a href="http://example.com" style="color:#aaaaaa;text-decoration:underline">link</a>'); expect($output)->stringContainsString('<a href="http://example.com" style="color:#aaaaaa;text-decoration:underline">link</a>');
} }
public function testItRaisesExceptionIfTextIsNotString() {
$this->block['text'] = ['some', 'array'];
$this->expectException('RuntimeException');
(new Header)->render($this->block);
}
} }