Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Improve test coverage for SendingQueue::processSending()

Browse Source 
While working on the previous commit, I noticed that we had a test to
check removing subscribers that are not part of a segment associated
with a newsletter when sending
(testItRemovesSubscribersFromProcessingListWhenNewsletterHasSegmentAndSubscriberIsNotPartOfIt()).
But SendingQueue::processSending() also handles removing subscribers
when sending newsletters without segments. And there was not test to
cover this part of the code.

[MAILPOET-5682]
This commit is contained in:
Rodrigo Primo
2023-11-21 22:17:41 -03:00
committed by Jan Jakeš
parent 876a9489a4
commit 0604d97212
1 changed files with 39 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
mailpoet/tests/integration/Cron/Workers/SendingQueue/SendingQueueTest.php
View File

@@ -906,6 +906,45 @@ class SendingQueueTest extends \MailPoetTest {
verify(count($statistics))->equals(1);
}
public function testItRemovesSubscribersFromProcessingListWhenNewsletterHasNoSegment() {
$this->newsletterEntity->getNewsletterSegments()->clear();
$invalidSubscriberId = 99999;
$this->scheduledTaskSubscribersRepository->setSubscribers(
$this->scheduledTask,
[$this->subscriber->getId(), $invalidSubscriberId]
);
$sendingQueueWorker = $this->sendingQueueWorker;
$sendingQueueWorker->mailerTask = $this->construct(
MailerTask::class,
[$this->diContainer->get(MailerFactory::class)],
[
'send' => Expected::exactly(1, function() {
return $this->mailerTaskDummyResponse;
}),
]
);
$sendingQueueWorker->process();
$scheduledTask = $this->scheduledTasksRepository->findOneBySendingQueue($this->sendingQueue);
$this->assertInstanceOf(ScheduledTaskEntity::class, $scheduledTask);
$this->sendingQueuesRepository->refresh($this->sendingQueue);
$this->scheduledTasksRepository->refresh($scheduledTask);
// queue subscriber processed/to process count is updated
verify($scheduledTask->getSubscribersByProcessed(ScheduledTaskSubscriberEntity::STATUS_UNPROCESSED))
->equals([]);
verify($scheduledTask->getSubscribersByProcessed(ScheduledTaskSubscriberEntity::STATUS_PROCESSED))
->equals([$this->subscriber]);
verify($this->sendingQueue->getCountTotal())->equals(1);
verify($this->sendingQueue->getCountProcessed())->equals(1);
verify($this->sendingQueue->getCountToProcess())->equals(0);
// statistics entry should be created only for 1 subscriber
$statistics = StatisticsNewsletters::findMany();
verify(count($statistics))->equals(1);
}
public function testItDoesNotCallMailerWithEmptyBatch() {
$subscribers = [];
while (count($subscribers) < 2 * SendingThrottlingHandler::BATCH_SIZE) {