Recalculate engagement score after open
[MAILPOET-3525]
This commit is contained in:
@ -232,6 +232,7 @@ class ContainerConfigurator implements IContainerConfigurator {
|
||||
$container->autowire(\MailPoet\Statistics\Track\WooCommercePurchases::class);
|
||||
$container->autowire(\MailPoet\Statistics\Track\Unsubscribes::class)->setPublic(true);
|
||||
$container->autowire(\MailPoet\Statistics\StatisticsFormsRepository::class)->setPublic(true);
|
||||
$container->autowire(\MailPoet\Statistics\StatisticsOpensRepository::class)->setPublic(true);
|
||||
$container->autowire(\MailPoet\Statistics\StatisticsUnsubscribesRepository::class);
|
||||
$container->autowire(\MailPoet\Statistics\StatisticsWooCommercePurchasesRepository::class)->setPublic(true);
|
||||
$container->autowire(\MailPoet\Router\Router::class)
|
||||
|
51
lib/Statistics/StatisticsOpensRepository.php
Normal file
51
lib/Statistics/StatisticsOpensRepository.php
Normal file
@ -0,0 +1,51 @@
|
||||
<?php declare(strict_types=1);
|
||||
|
||||
namespace MailPoet\Statistics;
|
||||
|
||||
use MailPoet\Doctrine\Repository;
|
||||
use MailPoet\Entities\ScheduledTaskSubscriberEntity;
|
||||
use MailPoet\Entities\StatisticsOpenEntity;
|
||||
use MailPoet\Entities\SubscriberEntity;
|
||||
use MailPoet\Tasks\Sending;
|
||||
|
||||
/**
|
||||
* @extends Repository<StatisticsOpensEntity>
|
||||
*/
|
||||
class StatisticsOpensRepository extends Repository {
|
||||
protected function getEntityClassName(): string {
|
||||
return StatisticsOpenEntity::class;
|
||||
}
|
||||
|
||||
public function recalculateSubscriberScore(SubscriberEntity $subscriber): void {
|
||||
$subscriber->setEngagementScoreUpdatedAt(new \DateTimeImmutable());
|
||||
$newslettersSentCount = $this
|
||||
->entityManager
|
||||
->createQueryBuilder()
|
||||
->select('count(DISTINCT task.id)')
|
||||
->from(ScheduledTaskSubscriberEntity::class, 'scheduledTaskSubscriber')
|
||||
->where('scheduledTaskSubscriber.subscriber = :subscriber')
|
||||
->setParameter('subscriber', $subscriber)
|
||||
->join('scheduledTaskSubscriber.task', 'task')
|
||||
->andWhere('task.type = :sending')
|
||||
->setParameter('sending', Sending::TASK_TYPE)
|
||||
->getQuery()
|
||||
->getSingleScalarResult();
|
||||
if ($newslettersSentCount < 3) {
|
||||
$this->entityManager->flush();
|
||||
return;
|
||||
}
|
||||
$opens = $this
|
||||
->entityManager
|
||||
->createQueryBuilder()
|
||||
->select('count(DISTINCT opens.newsletter)')
|
||||
->from(StatisticsOpenEntity::class, 'opens')
|
||||
->where('opens.subscriber = :subscriberId')
|
||||
->setParameter('subscriberId', $subscriber)
|
||||
->getQuery()
|
||||
->getSingleScalarResult();
|
||||
$score = (int)round(($opens / $newslettersSentCount) * 100);
|
||||
$subscriber->setEngagementScore($score);
|
||||
$this->entityManager->flush();
|
||||
}
|
||||
|
||||
}
|
@ -6,8 +6,16 @@ use MailPoet\Entities\NewsletterEntity;
|
||||
use MailPoet\Entities\SendingQueueEntity;
|
||||
use MailPoet\Entities\SubscriberEntity;
|
||||
use MailPoet\Models\StatisticsOpens;
|
||||
use MailPoet\Statistics\StatisticsOpensRepository;
|
||||
|
||||
class Opens {
|
||||
/** @var StatisticsOpensRepository */
|
||||
private $statisticsOpensRepository;
|
||||
|
||||
public function __construct(StatisticsOpensRepository $statisticsOpensRepository) {
|
||||
$this->statisticsOpensRepository = $statisticsOpensRepository;
|
||||
}
|
||||
|
||||
public function track($data, $displayImage = true) {
|
||||
if (!$data) {
|
||||
return $this->returnResponse($displayImage);
|
||||
@ -27,6 +35,7 @@ class Opens {
|
||||
$newsletter->getId(),
|
||||
$queue->getId()
|
||||
);
|
||||
$this->statisticsOpensRepository->recalculateSubscriberScore($subscriber);
|
||||
}
|
||||
return $this->returnResponse($displayImage);
|
||||
}
|
||||
|
105
tests/integration/Statistics/StatisticsOpensRepositoryTest.php
Normal file
105
tests/integration/Statistics/StatisticsOpensRepositoryTest.php
Normal file
@ -0,0 +1,105 @@
|
||||
<?php declare(strict_types = 1);
|
||||
|
||||
namespace MailPoet\Statistics;
|
||||
|
||||
use MailPoet\Entities\NewsletterEntity;
|
||||
use MailPoet\Entities\ScheduledTaskEntity;
|
||||
use MailPoet\Entities\ScheduledTaskSubscriberEntity;
|
||||
use MailPoet\Entities\SendingQueueEntity;
|
||||
use MailPoet\Entities\StatisticsOpenEntity;
|
||||
use MailPoet\Entities\SubscriberEntity;
|
||||
use MailPoet\Subscribers\SubscribersRepository;
|
||||
use MailPoet\Tasks\Sending;
|
||||
use MailPoetVendor\Carbon\CarbonImmutable;
|
||||
|
||||
class StatisticsFormsRepositoryTest extends \MailPoetTest {
|
||||
/** @var StatisticsOpensRepository */
|
||||
private $repository;
|
||||
|
||||
/** @var SubscribersRepository */
|
||||
private $subscribersRepository;
|
||||
|
||||
public function _before() {
|
||||
parent::_before();
|
||||
$this->cleanup();
|
||||
$this->repository = $this->diContainer->get(StatisticsOpensRepository::class);
|
||||
$this->subscribersRepository = $this->diContainer->get(SubscribersRepository::class);
|
||||
}
|
||||
|
||||
public function testItLeavesScoreWhenNoData() {
|
||||
$subscriber = $this->createSubscriber();
|
||||
$this->entityManager->flush();
|
||||
$this->repository->recalculateSubscriberScore($subscriber);
|
||||
$newSubscriber = $this->subscribersRepository->findOneById($subscriber->getId());
|
||||
expect($newSubscriber->getEngagementScore())->null();
|
||||
expect($newSubscriber->getEngagementScoreUpdatedAt())->notNull();
|
||||
}
|
||||
|
||||
public function testItUpdatesScoreTimeWhenNotEnoughNewsletters() {
|
||||
$subscriber = $this->createSubscriber();
|
||||
$subscriber->setEngagementScoreUpdatedAt((new CarbonImmutable())->subDays(4));
|
||||
$this->createSendingTask($subscriber);
|
||||
$this->entityManager->flush();
|
||||
$this->repository->recalculateSubscriberScore($subscriber);
|
||||
$newSubscriber = $this->subscribersRepository->findOneById($subscriber->getId());
|
||||
expect($newSubscriber->getEngagementScore())->null();
|
||||
expect($newSubscriber->getEngagementScoreUpdatedAt())->notNull();
|
||||
$scoreUpdatedAt = new CarbonImmutable($newSubscriber->getEngagementScoreUpdatedAt());
|
||||
expect($scoreUpdatedAt->isAfter((new CarbonImmutable())->subMinutes(5)))->true();
|
||||
}
|
||||
|
||||
public function testItUpdatesScore() {
|
||||
$subscriber = $this->createSubscriber();
|
||||
$subscriber->setEngagementScoreUpdatedAt((new CarbonImmutable())->subDays(4));
|
||||
$this->createSendingTask($subscriber);
|
||||
$this->createSendingTask($subscriber);
|
||||
$task = $this->createSendingTask($subscriber);
|
||||
$newsletter = new NewsletterEntity();
|
||||
$this->entityManager->persist($newsletter);
|
||||
$queue = new SendingQueueEntity();
|
||||
$this->entityManager->persist($queue);
|
||||
$queue->setNewsletter($newsletter);
|
||||
$queue->setTask($task);
|
||||
$newsletter->getQueues()->add($queue);
|
||||
$newsletter->setSubject('newsletter 1');
|
||||
$newsletter->setStatus('sent');
|
||||
$newsletter->setType(NewsletterEntity::TYPE_STANDARD);
|
||||
$open = new StatisticsOpenEntity($newsletter, $queue, $subscriber);
|
||||
$this->entityManager->persist($open);
|
||||
$this->entityManager->flush();
|
||||
|
||||
$this->repository->recalculateSubscriberScore($subscriber);
|
||||
|
||||
$newSubscriber = $this->subscribersRepository->findOneById($subscriber->getId());
|
||||
expect($newSubscriber->getEngagementScore())->equals(33);
|
||||
expect($newSubscriber->getEngagementScoreUpdatedAt())->notNull();
|
||||
$scoreUpdatedAt = new CarbonImmutable($newSubscriber->getEngagementScoreUpdatedAt());
|
||||
expect($scoreUpdatedAt->isAfter((new CarbonImmutable())->subMinutes(5)))->true();
|
||||
}
|
||||
|
||||
private function createSubscriber(): SubscriberEntity {
|
||||
$subscriber = new SubscriberEntity();
|
||||
$subscriber->setStatus(SubscriberEntity::STATUS_SUBSCRIBED);
|
||||
$subscriber->setEmail('subscriber' . rand(0, 10000) . '@example.com');
|
||||
$this->entityManager->persist($subscriber);
|
||||
return $subscriber;
|
||||
}
|
||||
|
||||
private function createSendingTask(SubscriberEntity $subscriber): ScheduledTaskEntity {
|
||||
$task = new ScheduledTaskEntity();
|
||||
$task->setType(Sending::TASK_TYPE);
|
||||
$this->entityManager->persist($task);
|
||||
$sub = new ScheduledTaskSubscriberEntity($task, $subscriber);
|
||||
$this->entityManager->persist($sub);
|
||||
return $task;
|
||||
}
|
||||
|
||||
private function cleanup(): void {
|
||||
$this->truncateEntity(ScheduledTaskEntity::class);
|
||||
$this->truncateEntity(ScheduledTaskSubscriberEntity::class);
|
||||
$this->truncateEntity(StatisticsOpenEntity::class);
|
||||
$this->truncateEntity(SubscriberEntity::class);
|
||||
$this->truncateEntity(NewsletterEntity::class);
|
||||
$this->truncateEntity(SendingQueueEntity::class);
|
||||
}
|
||||
}
|
Reference in New Issue
Block a user