From 0805dc365fa41d4bb44c58ce694800bebf58c9ce Mon Sep 17 00:00:00 2001
From: wxa <wxa@users.noreply.github.com>
Date: Mon, 30 Sep 2019 08:01:55 +0300
Subject: [PATCH] Make startProgress() and stopProgress() methods private
 [MAILPOET-2385]

---
 lib/Cron/Workers/SingleInstanceSimpleWorker.php               | 4 ++--
 .../Cron/Workers/SingleInstanceSimpleWorkerTest.php           | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/Cron/Workers/SingleInstanceSimpleWorker.php b/lib/Cron/Workers/SingleInstanceSimpleWorker.php
index 481aaed3c0..e4ce1f8d89 100644
--- a/lib/Cron/Workers/SingleInstanceSimpleWorker.php
+++ b/lib/Cron/Workers/SingleInstanceSimpleWorker.php
@@ -48,12 +48,12 @@ abstract class SingleInstanceSimpleWorker extends SimpleWorker {
     return false;
   }
 
-  function startProgress(ScheduledTask $task) {
+  private function startProgress(ScheduledTask $task) {
     $task->meta = array_merge($task->getMeta(), ['in_progress' => true]);
     $task->save();
   }
 
-  function stopProgress(ScheduledTask $task) {
+  private function stopProgress(ScheduledTask $task) {
     $task->meta = array_merge($task->getMeta(), ['in_progress' => null]);
     $task->save();
   }
diff --git a/tests/integration/Cron/Workers/SingleInstanceSimpleWorkerTest.php b/tests/integration/Cron/Workers/SingleInstanceSimpleWorkerTest.php
index 99efe7de8b..1983ca50ce 100644
--- a/tests/integration/Cron/Workers/SingleInstanceSimpleWorkerTest.php
+++ b/tests/integration/Cron/Workers/SingleInstanceSimpleWorkerTest.php
@@ -21,8 +21,7 @@ class SingleInstanceSimpleWorkerTest extends \MailPoetTest {
     $task = $this->createScheduledTask();
     expect(empty($task->getMeta()['in_progress']))->equals(true);
     expect($this->worker->processTask($task))->equals(true);
-    $this->worker->startProgress($task);
-    expect(empty($task->getMeta()['in_progress']))->equals(false);
+    $task->meta = ['in_progress' => true];
     expect($this->worker->processTask($task))->equals(false);
   }