diff --git a/.eslintrc.es5.json b/.eslintrc.es5.json index b71eb15a65..d19db19022 100644 --- a/.eslintrc.es5.json +++ b/.eslintrc.es5.json @@ -14,7 +14,6 @@ - "comma-dangle": 0, "space-before-function-paren": 0, "prefer-arrow-callback": 0, "no-undef": 0, diff --git a/assets/js/src/analytics_event.js b/assets/js/src/analytics_event.js index eb6dbca947..23fea76bab 100644 --- a/assets/js/src/analytics_event.js +++ b/assets/js/src/analytics_event.js @@ -55,7 +55,7 @@ function cacheEvent(forced, name, data) { eventsCache.push({ name: name, data: data, - forced: forced, + forced: forced }); } diff --git a/assets/js/src/newsletter_editor/App.js b/assets/js/src/newsletter_editor/App.js index d1116eae9e..743c2891d3 100644 --- a/assets/js/src/newsletter_editor/App.js +++ b/assets/js/src/newsletter_editor/App.js @@ -15,8 +15,8 @@ define([ contentRegion: '#mailpoet_editor_content', sidebarRegion: '#mailpoet_editor_sidebar', bottomRegion: '#mailpoet_editor_bottom', - headingRegion: '#mailpoet_editor_heading', - }, + headingRegion: '#mailpoet_editor_heading' + } }); var EditorApplication = Marionette.Application.extend({ diff --git a/assets/js/src/newsletter_editor/behaviors/ColorPickerBehavior.js b/assets/js/src/newsletter_editor/behaviors/ColorPickerBehavior.js index ec9d4f34df..b0f2908e28 100644 --- a/assets/js/src/newsletter_editor/behaviors/ColorPickerBehavior.js +++ b/assets/js/src/newsletter_editor/behaviors/ColorPickerBehavior.js @@ -21,6 +21,6 @@ define([ chooseText: MailPoet.I18n.t('selectColor'), cancelText: MailPoet.I18n.t('cancelColorSelection') }); - }, + } }); }); diff --git a/assets/js/src/newsletter_editor/behaviors/ContainerDropZoneBehavior.js b/assets/js/src/newsletter_editor/behaviors/ContainerDropZoneBehavior.js index 285230c4c4..ceb4721209 100644 --- a/assets/js/src/newsletter_editor/behaviors/ContainerDropZoneBehavior.js +++ b/assets/js/src/newsletter_editor/behaviors/ContainerDropZoneBehavior.js @@ -15,7 +15,7 @@ define([ BehaviorsLookup.ContainerDropZoneBehavior = Marionette.Behavior.extend({ defaults: { - columnLimit: 3, + columnLimit: 3 }, onRender: function() { var dragAndDropDisabled = _.isObject(this.view.options.renderOptions) && this.view.options.renderOptions.disableDragAndDrop === true; @@ -195,7 +195,7 @@ define([ if (view.model.get('orientation') === 'horizontal' && droppableModel.get('type') !== 'container') { // Regular blocks always need to be inserted into columns - vertical containers tempCollection = new (EditorApplication.getBlockTypeModel('container'))({ - orientation: 'vertical', + orientation: 'vertical' }); tempCollection.get('blocks').add(droppableModel); viewCollection.add(tempCollection, {at: index}); @@ -210,7 +210,7 @@ define([ var tempModel = viewCollection.at(dropPosition.index); tempCollection = new (EditorApplication.getBlockTypeModel('container'))({ - orientation: (view.model.get('orientation') === 'vertical') ? 'horizontal' : 'vertical', + orientation: (view.model.get('orientation') === 'vertical') ? 'horizontal' : 'vertical' }); viewCollection.remove(tempModel); @@ -218,19 +218,19 @@ define([ if (tempCollection.get('orientation') === 'horizontal') { if (dropPosition.position === 'before') { tempCollection2 = new (EditorApplication.getBlockTypeModel('container'))({ - orientation: 'vertical', + orientation: 'vertical' }); tempCollection2.get('blocks').add(droppableModel); tempCollection.get('blocks').add(tempCollection2); } tempCollection2 = new (EditorApplication.getBlockTypeModel('container'))({ - orientation: 'vertical', + orientation: 'vertical' }); tempCollection2.get('blocks').add(tempModel); tempCollection.get('blocks').add(tempCollection2); if (dropPosition.position === 'after') { tempCollection2 = new (EditorApplication.getBlockTypeModel('container'))({ - orientation: 'vertical', + orientation: 'vertical' }); tempCollection2.get('blocks').add(droppableModel); tempCollection.get('blocks').add(tempCollection2); @@ -254,11 +254,11 @@ define([ event.draggable.onDrop({ dropBehavior: that, droppedModel: droppableModel, - droppedView: droppedView, + droppedView: droppedView }); that.cleanup(); - }, + } }); }, cleanup: function() { @@ -296,7 +296,7 @@ define([ return { insertionType: 'normal', index: 0, - position: 'inside', + position: 'inside' }; } @@ -347,7 +347,7 @@ define([ return { insertionType: insertionType, // 'normal'|'special' index: index, - position: position, // 'inside'|'before'|'after' + position: position // 'inside'|'before'|'after' }; }, _computeNormalIndex: function(eventX, eventY) { @@ -377,13 +377,13 @@ define([ // First half of the element return { index: index, - position: 'before', + position: 'before' }; } else { // Second half of the element return { index: index, - position: 'after', + position: 'after' }; } }, diff --git a/assets/js/src/newsletter_editor/behaviors/DraggableBehavior.js b/assets/js/src/newsletter_editor/behaviors/DraggableBehavior.js index 69da0a7183..faf75ef8a6 100644 --- a/assets/js/src/newsletter_editor/behaviors/DraggableBehavior.js +++ b/assets/js/src/newsletter_editor/behaviors/DraggableBehavior.js @@ -28,7 +28,7 @@ define([ }, onDrop: function(model, view) {}, - testAttachToInstance: function(model, view) { return true; }, + testAttachToInstance: function(model, view) { return true; } }, onRender: function() { var that = this, @@ -38,7 +38,7 @@ define([ if (!this.options.testAttachToInstance(this.view.model, this.view)) return; interactable = interact(this.$el.get(0), { - ignoreFrom: this.options.ignoreSelector, + ignoreFrom: this.options.ignoreSelector }).draggable({ // allow dragging of multple elements at the same time max: Infinity, @@ -111,7 +111,7 @@ define([ that.view.$el.removeClass('mailpoet_hidden'); } } - }, + } }) .preventDefault('auto') .styleCursor(false) @@ -137,6 +137,6 @@ define([ // Delegate to view's event handler that.options.onDrop.apply(that, [options]); }; - }, + } }); }); diff --git a/assets/js/src/newsletter_editor/behaviors/HighlightEditingBehavior.js b/assets/js/src/newsletter_editor/behaviors/HighlightEditingBehavior.js index d87778027c..9b8fc3d513 100644 --- a/assets/js/src/newsletter_editor/behaviors/HighlightEditingBehavior.js +++ b/assets/js/src/newsletter_editor/behaviors/HighlightEditingBehavior.js @@ -5,19 +5,19 @@ */ define([ 'backbone.marionette', - 'newsletter_editor/behaviors/BehaviorsLookup', + 'newsletter_editor/behaviors/BehaviorsLookup' ], function(Marionette, BehaviorsLookup) { BehaviorsLookup.HighlightEditingBehavior = Marionette.Behavior.extend({ modelEvents: { 'startEditing': 'enableHighlight', - 'stopEditing': 'disableHighlight', + 'stopEditing': 'disableHighlight' }, enableHighlight: function() { this.$el.addClass('mailpoet_highlight'); }, disableHighlight: function() { this.$el.removeClass('mailpoet_highlight'); - }, + } }); }); diff --git a/assets/js/src/newsletter_editor/behaviors/ResizableBehavior.js b/assets/js/src/newsletter_editor/behaviors/ResizableBehavior.js index abd140002e..cf98cf5f85 100644 --- a/assets/js/src/newsletter_editor/behaviors/ResizableBehavior.js +++ b/assets/js/src/newsletter_editor/behaviors/ResizableBehavior.js @@ -15,11 +15,11 @@ define([ resizeHandleSelector: true, // true will use edges of the element itself transformationFunction: function(y) { return y; }, minLength: 0, - modelField: 'styles.block.height', + modelField: 'styles.block.height' }, events: { "mouseenter": 'showResizeHandle', - "mouseleave": 'hideResizeHandle', + "mouseleave": 'hideResizeHandle' }, onRender: function() { this.attachResize(); @@ -37,8 +37,8 @@ define([ top: false, left: false, right: false, - bottom: (typeof this.options.resizeHandleSelector === 'string') ? this.view.$(this.options.resizeHandleSelector).get(0) : this.options.resizeHandleSelector, - }, + bottom: (typeof this.options.resizeHandleSelector === 'string') ? this.view.$(this.options.resizeHandleSelector).get(0) : this.options.resizeHandleSelector + } }).on('resizestart', function(event) { that.isBeingResized = true; that.$el.addClass('mailpoet_resize_active'); @@ -63,6 +63,6 @@ define([ if (typeof this.options.resizeHandleSelector === 'string') { this.view.$(this.options.resizeHandleSelector).addClass('mailpoet_hidden'); } - }, + } }); }); diff --git a/assets/js/src/newsletter_editor/behaviors/ShowSettingsBehavior.js b/assets/js/src/newsletter_editor/behaviors/ShowSettingsBehavior.js index 086db95d47..a8acc62380 100644 --- a/assets/js/src/newsletter_editor/behaviors/ShowSettingsBehavior.js +++ b/assets/js/src/newsletter_editor/behaviors/ShowSettingsBehavior.js @@ -6,15 +6,15 @@ define([ 'backbone.marionette', 'jquery', - 'newsletter_editor/behaviors/BehaviorsLookup', + 'newsletter_editor/behaviors/BehaviorsLookup' ], function(Marionette, jQuery, BehaviorsLookup) { BehaviorsLookup.ShowSettingsBehavior = Marionette.Behavior.extend({ defaults: { - ignoreFrom: '', // selector + ignoreFrom: '' // selector }, events: { - 'click .mailpoet_content': 'showSettings', + 'click .mailpoet_content': 'showSettings' }, showSettings: function(event) { if(!this.isIgnoredElement(event.target)) { @@ -25,7 +25,7 @@ define([ return this.options.ignoreFrom && this.options.ignoreFrom.length > 0 && jQuery(element).is(this.options.ignoreFrom); - }, + } }); }); diff --git a/assets/js/src/newsletter_editor/behaviors/SortableBehavior.js b/assets/js/src/newsletter_editor/behaviors/SortableBehavior.js index e9d0a24e79..18bbb2b149 100644 --- a/assets/js/src/newsletter_editor/behaviors/SortableBehavior.js +++ b/assets/js/src/newsletter_editor/behaviors/SortableBehavior.js @@ -32,7 +32,7 @@ define([ collection.remove(model); collection.add(model, { at: newIndex }); }, - items: this.options.items, + items: this.options.items }); } } diff --git a/assets/js/src/newsletter_editor/behaviors/TextEditorBehavior.js b/assets/js/src/newsletter_editor/behaviors/TextEditorBehavior.js index 2474c2f827..a5808ecb46 100644 --- a/assets/js/src/newsletter_editor/behaviors/TextEditorBehavior.js +++ b/assets/js/src/newsletter_editor/behaviors/TextEditorBehavior.js @@ -18,7 +18,7 @@ define([ invalidElements: "script", blockFormats: 'Paragraph=p', plugins: "link textcolor colorpicker mailpoet_shortcodes", - configurationFilter: function(originalConfig) { return originalConfig; }, + configurationFilter: function(originalConfig) { return originalConfig; } }, onDomRefresh: function() { var that = this; @@ -76,7 +76,7 @@ define([ editor.on('blur', function(e) { that.view.triggerMethod('text:editor:blur'); }); - }, + } })); } }); diff --git a/assets/js/src/newsletter_editor/blocks/automatedLatestContent.js b/assets/js/src/newsletter_editor/blocks/automatedLatestContent.js index cf7dd38a0c..739a5c7cfe 100644 --- a/assets/js/src/newsletter_editor/blocks/automatedLatestContent.js +++ b/assets/js/src/newsletter_editor/blocks/automatedLatestContent.js @@ -53,7 +53,7 @@ define([ }); CommunicationComponent.getBulkTransformedPosts({ - blocks: blocks, + blocks: blocks }).then(_.partial(this.refreshBlocks, models)); }, refreshBlocks: function(models, renderedBlocks) { @@ -65,7 +65,7 @@ define([ model.trigger('refreshPosts', contents); } ); - }, + } }); Module.AutomatedLatestContentBlockModel = base.BlockModel.extend({ @@ -97,14 +97,14 @@ define([ sortBy: 'newest', // 'newest'|'oldest', showDivider: true, // true|false divider: {}, - _container: new (App.getBlockTypeModel('container'))(), + _container: new (App.getBlockTypeModel('container'))() }, App.getConfig().get('blockDefaults.automatedLatestContent')); }, relations: function() { return { readMoreButton: App.getBlockTypeModel('button'), divider: App.getBlockTypeModel('divider'), - _container: App.getBlockTypeModel('container'), + _container: App.getBlockTypeModel('container') }; }, initialize: function() { @@ -124,7 +124,7 @@ define([ */ _scheduleFetchPosts: function() { App.getChannel().trigger('automatedLatestContentRefresh'); - }, + } }); Module.AutomatedLatestContentBlockView = base.BlockView.extend({ @@ -138,15 +138,15 @@ define([ getTemplate: function() { return templates.automatedLatestContentBlock; }, regions: { toolsRegion: '.mailpoet_tools', - postsRegion: '.mailpoet_automated_latest_content_block_posts', + postsRegion: '.mailpoet_automated_latest_content_block_posts' }, modelEvents: _.extend( _.omit(base.BlockView.prototype.modelEvents, 'change'), { - 'postsChanged': 'render', + 'postsChanged': 'render' }), events: _.extend(base.BlockView.prototype.events, { - 'click .mailpoet_automated_latest_content_block_overlay': 'showSettings', + 'click .mailpoet_automated_latest_content_block_overlay': 'showSettings' }), onDragSubstituteBy: function() { return Module.AutomatedLatestContentWidgetView; }, onRender: function() { @@ -154,16 +154,16 @@ define([ renderOptions = { disableTextEditor: true, disableDragAndDrop: true, - emptyContainerMessage: MailPoet.I18n.t('noPostsToDisplay'), + emptyContainerMessage: MailPoet.I18n.t('noPostsToDisplay') }; this.toolsView = new Module.AutomatedLatestContentBlockToolsView({ model: this.model }); this.showChildView('toolsRegion', this.toolsView); this.showChildView('postsRegion', new ContainerView({ model: this.model.get('_container'), renderOptions: renderOptions })); - }, + } }); Module.AutomatedLatestContentBlockToolsView = base.BlockToolsView.extend({ - getSettingsView: function() { return Module.AutomatedLatestContentBlockSettingsView; }, + getSettingsView: function() { return Module.AutomatedLatestContentBlockSettingsView; } }); // Sidebar view container @@ -192,7 +192,7 @@ define([ "input .mailpoet_automated_latest_content_categories": _.partial(this.changeField, "categoriesPrecededBy"), "input .mailpoet_automated_latest_content_read_more_text": _.partial(this.changeField, "readMoreText"), "change .mailpoet_automated_latest_content_sort_by": _.partial(this.changeField, "sortBy"), - "click .mailpoet_done_editing": "close", + "click .mailpoet_done_editing": "close" }; }, onRender: function() { @@ -247,8 +247,8 @@ define([ } ) }; - }, - }, + } + } }).on({ 'select2:select': function(event) { var terms = that.model.get('terms'); @@ -261,7 +261,7 @@ define([ terms.remove(event.params.data); // Reset whole model in order for change events to propagate properly that.model.set('terms', terms.toJSON()); - }, + } }).trigger( 'change' ); }, toggleDisplayOptions: function(event) { @@ -282,8 +282,8 @@ define([ renderOptions: { displayFormat: 'subpanel', hideLink: true, - hideApplyToAll: true, - }, + hideApplyToAll: true + } })).render(); }, showDividerSettings: function(event) { @@ -292,8 +292,8 @@ define([ model: this.model.get('divider'), renderOptions: { displayFormat: 'subpanel', - hideApplyToAll: true, - }, + hideApplyToAll: true + } })).render(); }, changeReadMoreType: function(event) { @@ -356,11 +356,11 @@ define([ _.each(postTypes, function(type) { select.append(jQuery('