Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Reuse JiraController factory for other services

Browse Source 
[MAILPOET-1977]
This commit is contained in:
Jan Jakeš
2019-04-23 12:35:18 +02:00
committed by M. Shull
parent f9b7ece35e
commit 09d1f2cd99
3 changed files with 4 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
RoboFile.php
View File

@ -685,18 +685,15 @@ class RoboFile extends \Robo\Tasks {
} }
protected function getChangelogController() { protected function getChangelogController() {
return \MailPoetTasks\Release\ChangelogController::createWithJiraCredentials( return new \MailPoetTasks\Release\ChangelogController(
getenv('WP_JIRA_TOKEN'), $this->createJiraController(),
getenv('WP_JIRA_USER'),
\MailPoetTasks\Release\JiraController::PROJECT_MAILPOET,
__DIR__ . '/readme.txt' __DIR__ . '/readme.txt'
); );
} }
protected function getReleaseVersionController() { protected function getReleaseVersionController() {
return \MailPoetTasks\Release\ReleaseVersionController::createWithJiraCredentials( return new \MailPoetTasks\Release\ReleaseVersionController(
getenv('WP_JIRA_TOKEN'), $this->createJiraController(),
getenv('WP_JIRA_USER'),
\MailPoetTasks\Release\JiraController::PROJECT_MAILPOET \MailPoetTasks\Release\JiraController::PROJECT_MAILPOET
); );
} }

4
tasks/release/ChangelogController.php
View File

@ -18,10 +18,6 @@ class ChangelogController {
$this->readme_file = $readme_file; $this->readme_file = $readme_file;
} }
static function createWithJiraCredentials($token, $user, $project, $readme_file) {
return new self(new JiraController($token, $user, $project), $readme_file);
}
function update($version_name = null) { function update($version_name = null) {
$changelog_data = $this->get($version_name); $changelog_data = $this->get($version_name);
$this->updateReadme($changelog_data[0], $changelog_data[1]); $this->updateReadme($changelog_data[0], $changelog_data[1]);

4
tasks/release/ReleaseVersionController.php
View File

@ -15,10 +15,6 @@ class ReleaseVersionController {
$this->project = $project; $this->project = $project;
} }
static function createWithJiraCredentials($token, $user, $project) {
return new self(new JiraController($token, $user, $project), $project);
}
function assignVersionToCompletedTickets($version = null) { function assignVersionToCompletedTickets($version = null) {
$version = $this->ensureCorrectVersion($version); $version = $this->ensureCorrectVersion($version);
if (!$version) { if (!$version) {