Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Improve readability

Browse Source 
[MAILPOET-4935]
This commit is contained in:
David Remer
2023-03-27 14:52:45 +03:00
committed by Aschepikov
parent ce6c9dfcdb
commit 0d12c05fb9
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
mailpoet/lib/Automation/Integrations/MailPoet/SubjectTransformers/OrderSubjectToSubscriberSubjectTransformer.php
View File

@ -34,23 +34,23 @@ class OrderSubjectToSubscriberSubjectTransformer implements SubjectTransformer {
public function transform(Subject $data): Subject { public function transform(Subject $data): Subject {
if ($this->accepts() !== $data->getKey()) { if ($this->accepts() !== $data->getKey()) {
throw new \InvalidArgumentException('Invalid subject type'); throw new \InvalidArgumentException('Invalid subject type');
} }
$subscriber = $this->findOrCreateSubscriber($data); $subscriber = $this->findOrCreateSubscriber($data);
if (!$subscriber instanceof SubscriberEntity) { if (!$subscriber instanceof SubscriberEntity) {
throw new \InvalidArgumentException('Subscriber not found'); throw new \InvalidArgumentException('Subscriber not found');
} }
return new Subject(SubscriberSubject::KEY, ['subscriber_id' => $subscriber->getId()]); return new Subject(SubscriberSubject::KEY, ['subscriber_id' => $subscriber->getId()]);
} }
public function accepts(): string { public function accepts(): string {
return OrderSubject::KEY; return OrderSubject::KEY;
} }
public function returns(): string { public function returns(): string {
return SubscriberSubject::KEY; return SubscriberSubject::KEY;
} }
private function findOrCreateSubscriber(Subject $order): ?SubscriberEntity { private function findOrCreateSubscriber(Subject $order): ?SubscriberEntity {
@ -75,6 +75,8 @@ class OrderSubjectToSubscriberSubjectTransformer implements SubjectTransformer {
} }
$wcOrder = $this->woocommerceHelper->wcGetOrder($orderId); $wcOrder = $this->woocommerceHelper->wcGetOrder($orderId);
$billingEmail = $wcOrder->get_billing_email(); $billingEmail = $wcOrder->get_billing_email();
return $billingEmail ? $this->subscribersRepository->findOneBy(['email' => $billingEmail]) : $this->subscribersRepository->findOneBy(['wpUserId' => $wcOrder->get_user_id()]); return $billingEmail ?
$this->subscribersRepository->findOneBy(['email' => $billingEmail]) :
$this->subscribersRepository->findOneBy(['wpUserId' => $wcOrder->get_user_id()]);
} }
} }