diff --git a/lib/Newsletter/Shortcodes/Categories/Date.php b/lib/Newsletter/Shortcodes/Categories/Date.php index 0a1e72beb9..8bea0a15d6 100644 --- a/lib/Newsletter/Shortcodes/Categories/Date.php +++ b/lib/Newsletter/Shortcodes/Categories/Date.php @@ -14,4 +14,4 @@ class Date { ); return (isset($actions[$action])) ? $actions[$action] : false; } -} +} \ No newline at end of file diff --git a/lib/Newsletter/Shortcodes/Categories/Link.php b/lib/Newsletter/Shortcodes/Categories/Link.php index 8968fe27c3..e63f4f1ed2 100644 --- a/lib/Newsletter/Shortcodes/Categories/Link.php +++ b/lib/Newsletter/Shortcodes/Categories/Link.php @@ -125,4 +125,4 @@ class Link { private static function getShortcode($action) { return sprintf('[link:%s]', $action); } -} +} \ No newline at end of file diff --git a/lib/Newsletter/Shortcodes/Categories/Newsletter.php b/lib/Newsletter/Shortcodes/Categories/Newsletter.php index 3f96e72ecb..785ca33c94 100644 --- a/lib/Newsletter/Shortcodes/Categories/Newsletter.php +++ b/lib/Newsletter/Shortcodes/Categories/Newsletter.php @@ -1,9 +1,10 @@ subject : false; case 'total': return substr_count($content, 'data-post-id'); @@ -27,9 +28,9 @@ class Newsletter { return ($latest_post) ? $latest_post['post_title'] : false; case 'number': - if($newsletter['type'] !== NewsletterModel::TYPE_NOTIFICATION_HISTORY) return false; + if($newsletter->type !== NewsletterModel::TYPE_NOTIFICATION_HISTORY) return false; $sent_newsletters = - NewsletterModel::where('parent_id', $newsletter['parent_id']) + NewsletterModel::where('parent_id', $newsletter->parent_id) ->where('status', NewsletterModel::STATUS_SENT) ->count(); return ++$sent_newsletters; diff --git a/lib/Newsletter/Shortcodes/Categories/Subscriber.php b/lib/Newsletter/Shortcodes/Categories/Subscriber.php index 12cd250c32..f69911dd09 100644 --- a/lib/Newsletter/Shortcodes/Categories/Subscriber.php +++ b/lib/Newsletter/Shortcodes/Categories/Subscriber.php @@ -1,5 +1,6 @@ first_name : $default_value; case 'lastname': - return ($subscriber) ? $subscriber['last_name'] : $default_value; + return ($subscriber) ? $subscriber->last_name : $default_value; case 'email': - return ($subscriber) ? $subscriber['email'] : false; + return ($subscriber) ? $subscriber->email : false; case 'displayname': - if($subscriber && $subscriber['wp_user_id']) { - $wp_user = get_userdata($subscriber['wp_user_id']); + if($subscriber && $subscriber->wp_user_id) { + $wp_user = get_userdata($subscriber->wp_user_id); return $wp_user->user_login; } return $default_value; @@ -31,10 +32,10 @@ class Subscriber { ->count(); default: if(preg_match('/cf_(\d+)/', $action, $custom_field) && - !empty($subscriber['id']) + !empty($subscriber->id) ) { $custom_field = SubscriberCustomField - ::where('subscriber_id', $subscriber['id']) + ::where('subscriber_id', $subscriber->id) ->where('custom_field_id', $custom_field[1]) ->findOne(); return ($custom_field) ? $custom_field->value : false; diff --git a/lib/Newsletter/Shortcodes/Shortcodes.php b/lib/Newsletter/Shortcodes/Shortcodes.php index e123c14960..53009386cd 100644 --- a/lib/Newsletter/Shortcodes/Shortcodes.php +++ b/lib/Newsletter/Shortcodes/Shortcodes.php @@ -12,15 +12,9 @@ class Shortcodes { $subscriber = false, $queue = false ) { - $this->newsletter = (is_object($newsletter)) ? - $newsletter->asArray() : - $newsletter; - $this->subscriber = (is_object($subscriber)) ? - $subscriber->asArray() : - $subscriber; - $this->queue = (is_object($queue)) ? - $queue->asArray() : - $queue; + $this->newsletter = $newsletter; + $this->subscriber = $subscriber; + $this->queue = $queue; } function extract($content, $categories = false) {