Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Do not save defaults for containers

Browse Source
This commit is contained in:
Tautvidas Sipavičius
2018-03-22 18:36:54 +02:00
committed by pavel-mailpoet
parent eb4d2ab829
commit 0d514a8084
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
assets/js/src/newsletter_editor/blocks/container.js
View File

@ -48,6 +48,7 @@ define([
blocks: new BlockCollection() blocks: new BlockCollection()
}, App.getConfig().get('blockDefaults.container')); }, App.getConfig().get('blockDefaults.container'));
}, },
_updateDefaults: function updateDefaults() {},
validate: function () { validate: function () {
// Recursively propagate validation checks to blocks in the tree // Recursively propagate validation checks to blocks in the tree
var invalidBlock = this.get('blocks').find(function (block) { return !block.isValid(); }); var invalidBlock = this.get('blocks').find(function (block) { return !block.isValid(); });

8
tests/javascript/newsletter_editor/blocks/container.spec.js
View File

@ -50,6 +50,14 @@ define([
expect(innerModel.get('styles.block.backgroundColor')).to.equal('#123456'); expect(innerModel.get('styles.block.backgroundColor')).to.equal('#123456');
}); });
it('do not update blockDefaults.container when changed', function () {
var sandbox = sinon.sandbox.create();
var stub = sandbox.stub(EditorApplication.getConfig(), 'set');
model.trigger('change');
expect(stub.callCount).to.equal(0);
sandbox.restore();
});
}); });
describe('when creating with children', function () { describe('when creating with children', function () {