Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Move Setting getValue and setValue to controller as a private methods

Browse Source 
[MAILPOET-1757]
This commit is contained in:
Rostislav Wolny
2019-01-30 17:48:09 +01:00
parent 2c921a16aa
commit 10e56d860d
6 changed files with 54 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
tests/integration/Models/SettingTest.php
View File

@ -23,12 +23,12 @@ class SettingTest extends \MailPoetTest {
}
function testItCanGetAllSettings() {
Setting::setValue('key_1', 'value_1');
Setting::setValue('key_2', 'value_2');
Setting::setValue('key_3', array(
Setting::createOrUpdate(['name' => 'key_1', 'value' => 'value_1']);
Setting::createOrUpdate(['name' => 'key_2', 'value' => 'value_2']);
Setting::createOrUpdate(['name' => 'key_3', 'value' => serialize([
'subkey_1' => 'subvalue_1',
'subkey_2' => 'subvalue_2'
));
])]);
$settings = Setting::getAll();
expect($settings['key_1'])->equals('value_1');
@ -39,20 +39,6 @@ class SettingTest extends \MailPoetTest {
));
}
function testItCanSetAndGetValues() {
// try to get an "unknown" key
$setting = Setting::getValue('unknown_key');
expect($setting)->equals(null);
// setting a "known" key
$setting = Setting::setValue('known_key', ' actual_value ');
expect($setting)->equals(true);
// try to get a "known" key
$setting = Setting::getValue('known_key', 'default_value');
expect($setting)->equals('actual_value');
}
function testItCanCreateOrUpdate() {
$data = array(
'name' => 'new',
@ -75,19 +61,6 @@ class SettingTest extends \MailPoetTest {
expect($setting->value)->equals('new data');
}
function testItCanGetAndSetValue() {
expect(Setting::setValue('test', ' 123 '))->true();
expect(Setting::getValue('test'))->equals('123');
}
function testItCanSetValueToNull() {
expect(Setting::setValue('test_key', true))->true();
expect(Setting::getValue('test_key'))->equals(true);
expect(Setting::setValue('test_key', null))->true();
expect(Setting::getValue('test_key'))->null();
}
function testSaveDefaultSenderIfNeededNotSaveEmptyValue() {
$settings_controller = new SettingsController();
Setting::saveDefaultSenderIfNeeded('', null);