Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Merge pull request #1516 from mailpoet/listings-warning

Browse Source 
Emails listing JS warning fix [MAILPOET-1537]
This commit is contained in:
Michelle Shull
2018-09-20 14:54:34 -04:00
committed by GitHub
parent 02e1f7f6dc 4ae1f4a107
commit 15b4f7feb1
1 changed files with 45 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
assets/js/src/listing/listing.jsx
View File

@@ -456,9 +456,9 @@ const Listing = React.createClass({
this.initWithParams(params); this.initWithParams(params);
}, },
getItems: function getItems() { getItems: function getItems() {
if (this.isComponentMounted) { if (!this.isComponentMounted) return;
this.setState({ loading: true });
this.setState({ loading: true });
this.clearSelection(); this.clearSelection();
MailPoet.Ajax.post({ MailPoet.Ajax.post({
@@ -476,8 +476,10 @@ const Listing = React.createClass({
sort_order: this.state.sort_order, sort_order: this.state.sort_order,
}, },
}).always(() => { }).always(() => {
if (!this.isComponentMounted) return;
this.setState({ loading: false }); this.setState({ loading: false });
}).done((response) => { }).done((response) => {
if (!this.isComponentMounted) return;
this.setState({ this.setState({
items: response.data || [], items: response.data || [],
filters: response.meta.filters || {}, filters: response.meta.filters || {},
@@ -504,7 +506,6 @@ const Listing = React.createClass({
); );
} }
}); });
}
}, },
handleRestoreItem: function handleRestoreItem(id) { handleRestoreItem: function handleRestoreItem(id) {
this.setState({ this.setState({