From 167fb8692780c9178b9d335965f277bb7281d1b4 Mon Sep 17 00:00:00 2001
From: Vlad <site.github@mrcasual.com>
Date: Wed, 14 Jun 2017 22:40:21 -0400
Subject: [PATCH] Adds manifest to JS assets Adds conditional assets caching
 based on environment

---
 package.json      |  7 +++--
 webpack.config.js | 78 ++++++++++++++++++++++++++++++++---------------
 2 files changed, 59 insertions(+), 26 deletions(-)

diff --git a/package.json b/package.json
index bd8c20aa45..d4baebcb35 100644
--- a/package.json
+++ b/package.json
@@ -38,6 +38,7 @@
     "amd-inject-loader": "~0.5.0",
     "babel-core": "^5.8.22",
     "babel-loader": "^5.3.2",
+    "clean-webpack-plugin": "^0.1.16",
     "chai": "2.2.0",
     "chai-jq": "0.0.8",
     "eslint": "^3.19.0",
@@ -56,6 +57,8 @@
     "sinon": "1.14.1",
     "sinon-chai": "2.7.0",
     "stylus": "~0.54.5",
-    "webpack": "1.11.0"
+    "webpack": "1.11.0",
+    "webpack-manifest-plugin": "^1.1.0",
+    "webpack-md5-hash": "0.0.5"
   }
-}
+}
\ No newline at end of file
diff --git a/webpack.config.js b/webpack.config.js
index 39b6c4461b..a2f2210c37 100644
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -1,11 +1,16 @@
-var webpack = require('webpack'),
-    _ = require('underscore'),
-    path = require('path'),
-    baseConfig = {},
-    config = [],
-    globalPrefix = 'MailPoetLib';
+var webpack = require('webpack');
+var webpackManifestPlugin = require('webpack-manifest-plugin');
+var webpackMD5HashPlugin = require('webpack-md5-hash');
+var webpackCleanPlugin = require('clean-webpack-plugin');
+var _ = require('underscore');
+var path = require('path');
+var globalPrefix = 'MailPoetLib';
+var PRODUCTION_ENV = process.env.NODE_ENV === 'production';
+var manifestCache = {};
 
-baseConfig = {
+// Base config
+var baseConfig = {
+  cache: true,
   context: __dirname,
   watch: {
     aggregateTimeout: 300,
@@ -13,7 +18,8 @@ baseConfig = {
   },
   output: {
     path: './assets/js',
-    filename: '[name].js',
+    filename: (PRODUCTION_ENV) ? '[name].[chunkhash:8].js' : '[name].js',
+    chunkFilename: (PRODUCTION_ENV) ? '[name].[chunkhash:8].chunk.js' : '[name].chunk.js'
   },
   resolve: {
     modulesDirectories: [
@@ -38,6 +44,11 @@ baseConfig = {
   node: {
     fs: 'empty'
   },
+  plugins: [
+    new webpackCleanPlugin([
+      './assets/js/*.*',
+    ])
+  ],
   module: {
     loaders: [
       {
@@ -120,8 +131,8 @@ baseConfig = {
   }
 };
 
-// Admin
-config.push(_.extend({}, baseConfig, {
+// Admin config
+var adminConfig = {
   name: 'admin',
   entry: {
     vendor: [
@@ -213,17 +224,26 @@ config.push(_.extend({}, baseConfig, {
     ]
   },
   plugins: [
-    new webpack.optimize.CommonsChunkPlugin('admin_vendor', 'admin_vendor.js', ['admin_vendor', 'admin']),
-    new webpack.optimize.CommonsChunkPlugin('vendor', 'vendor.js')
+    new webpack.optimize.CommonsChunkPlugin({
+      name: 'admin_vendor',
+      fileName: 'admin_vendor.js',
+      chunks: ['admin_vendor', 'admin'],
+      minChunks: Infinity
+    }),
+    new webpack.optimize.CommonsChunkPlugin({
+      name: 'vendor',
+      fileName: 'vendor.js',
+      minChunks: Infinity
+    })
   ],
   externals: {
     'jquery': 'jQuery',
     'tinymce': 'tinymce'
   }
-}));
+};
 
-// Public
-config.push(_.extend({}, baseConfig, {
+// Public config
+var publicConfig = {
   name: 'public',
   entry: {
     public: [
@@ -237,10 +257,10 @@ config.push(_.extend({}, baseConfig, {
   externals: {
     'jquery': 'jQuery'
   }
-}));
+};
 
-// mp2migrator
-config.push(_.extend({}, baseConfig, {
+// Migrator config
+var migratorConfig = {
   name: 'mp2migrator',
   entry: {
     mp2migrator: [
@@ -251,10 +271,9 @@ config.push(_.extend({}, baseConfig, {
     'jquery': 'jQuery',
     'mailpoet': 'MailPoet'
   }
-}));
-
-// Test
-config.push(_.extend({}, baseConfig, {
+};
+// Test config
+var testConfig = {
   name: 'test',
   entry: {
     vendor: ['handlebars', 'handlebars_helpers'],
@@ -348,6 +367,17 @@ config.push(_.extend({}, baseConfig, {
     'interact': 'interact',
     'spectrum': 'spectrum',
   }
-}));
+};
 
-module.exports = config;
+module.exports = _.map([adminConfig, publicConfig, migratorConfig, testConfig], function (config) {
+  if (config.name !== 'test') {
+    config.plugins = config.plugins || [];
+    config.plugins.push(
+      new webpackMD5HashPlugin(),
+      new webpackManifestPlugin({
+        cache: manifestCache
+      })
+    );
+  }
+  return _.extend({}, baseConfig, config);
+});
\ No newline at end of file