From 171866923ca5f73bbb64a6209246b6c939d0b427 Mon Sep 17 00:00:00 2001 From: Rostislav Wolny Date: Wed, 15 Jan 2020 13:30:46 +0100 Subject: [PATCH] Add acceptance test for creating a custom field [MAILPOET-2463] --- .../add_custom_field_form.jsx | 5 +- .../custom_radio/custom_field_settings.jsx | 3 +- .../blocks/custom_radio/settings_preview.jsx | 2 + .../form_editor/blocks/custom_select/edit.jsx | 2 +- .../FormEditorCreateCustomFieldCest.php | 68 +++++++++++++++++++ 5 files changed, 77 insertions(+), 3 deletions(-) create mode 100644 tests/acceptance/FormEditorCreateCustomFieldCest.php diff --git a/assets/js/src/form_editor/blocks/add_custom_field/add_custom_field_form.jsx b/assets/js/src/form_editor/blocks/add_custom_field/add_custom_field_form.jsx index 9dbcf27a8a..d140a6e2f2 100644 --- a/assets/js/src/form_editor/blocks/add_custom_field/add_custom_field_form.jsx +++ b/assets/js/src/form_editor/blocks/add_custom_field/add_custom_field_form.jsx @@ -97,11 +97,12 @@ const AddCustomFieldForm = ({ dateSettings, onSubmit }) => { }; return ( -
+

{ setFieldSettings(null); setFieldType(value); @@ -110,6 +111,7 @@ const AddCustomFieldForm = ({ dateSettings, onSubmit }) => {
{renderSettingsForType()} @@ -117,6 +119,7 @@ const AddCustomFieldForm = ({ dateSettings, onSubmit }) => { isLarge isDefault disabled={!canSubmit()} + data-automation-id="create_custom_field_submit" onClick={() => { const data = { name: fieldName, diff --git a/assets/js/src/form_editor/blocks/custom_radio/custom_field_settings.jsx b/assets/js/src/form_editor/blocks/custom_radio/custom_field_settings.jsx index f93a740401..cfb4419de8 100644 --- a/assets/js/src/form_editor/blocks/custom_radio/custom_field_settings.jsx +++ b/assets/js/src/form_editor/blocks/custom_radio/custom_field_settings.jsx @@ -50,7 +50,7 @@ const CustomFieldSettings = ({ }, [localData, onChange]); return ( -
+
{onSave ? ( diff --git a/assets/js/src/form_editor/blocks/custom_radio/settings_preview.jsx b/assets/js/src/form_editor/blocks/custom_radio/settings_preview.jsx index 1a9b4dafe0..37da76624c 100644 --- a/assets/js/src/form_editor/blocks/custom_radio/settings_preview.jsx +++ b/assets/js/src/form_editor/blocks/custom_radio/settings_preview.jsx @@ -15,6 +15,7 @@ const PreviewItem = ({ }) => (
onUpdate(value.id, event.target.value)} /> { return ( <> {inspectorControls} -
+
{!attributes.labelWithinInput ? (