Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove last usages of Subscriber model from the Pages class

Browse Source 
[MAILPOET-4020]
This commit is contained in:
Rodrigo Primo
2022-03-24 11:42:08 -03:00
committed by Veljko V
parent 794c7eb16f
commit 17f562a9c5
3 changed files with 25 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
mailpoet/lib/Subscription/ManageSubscriptionFormRenderer.php
View File

@@ -65,7 +65,23 @@ class ManageSubscriptionFormRenderer {
$this->subscribersRepository = $subscribersRepository;
}
public function renderForm(Subscriber $subscriber, string $formState = self::FORM_STATE_NOT_SUBMITTED): string {
public function renderForm(SubscriberEntity $subscriberEntity, string $formState = self::FORM_STATE_NOT_SUBMITTED): string {
// Once the old Subscriber model is removed from this class, the if below can be removed as well and $subscriberEntity
// can be used directly (probably worth renaming it to $subscriber). For now this if is needed, as when previewing the
// manage subscription page, a demo object is created in Pages::getManageContent() that is not persisted to the database
// so $subscriberEntity->getId() is null and thus it is not possible to use Subscriber::findOne() to get the old model.
if ($subscriberEntity->getId()) {
$subscriber = Subscriber::findOne($subscriberEntity->getId())->withSubscriptions()->withCustomFields();
} else {
$subscriber = Subscriber::create();
$subscriber->hydrate([
'email' => $subscriberEntity->getEmail(),
'first_name' => $subscriberEntity->getFirstName(),
'last_name' => $subscriberEntity->getLastName(),
'link_token' => $subscriberEntity->getLinkToken(),
]);
}
$basicFields = $this->getBasicFields($subscriber);
$customFields = $this->getCustomFields($subscriber);
$segmentField = $this->getSegmentField($subscriber);