Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add a new test for creating a custom field

Browse Source 
[MAILPOET-3628]
This commit is contained in:
Pavel Dohnal
2021-09-22 10:50:11 +02:00
committed by Veljko V
parent 04c2061c12
commit 1aa93d1b3c
3 changed files with 28 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/API/MP/v1/CustomFields.php
View File

@@ -67,7 +67,7 @@ class CustomFields {
try { try {
$customField = $this->customFieldsRepository->createOrUpdate($this->customFieldsDataSanitizer->sanitize($data)); $customField = $this->customFieldsRepository->createOrUpdate($this->customFieldsDataSanitizer->sanitize($data));
} catch (\Exception $e) { } catch (\Exception $e) {
throw new APIException('Failed to save a new subscriber field ' . join(', ', $e->getMessage()), APIException::FAILED_TO_SAVE_SUBSCRIBER_FIELD); throw new APIException('Failed to save a new subscriber field ' . $e->getMessage(), APIException::FAILED_TO_SAVE_SUBSCRIBER_FIELD);
} }
$customField = $this->customFieldsRepository->findOneById($customField->getId()); $customField = $this->customFieldsRepository->findOneById($customField->getId());
if (!$customField instanceof CustomFieldEntity) { if (!$customField instanceof CustomFieldEntity) {

1
tests/integration/API/MP/APITest.php
View File

@@ -6,7 +6,6 @@ use Codeception\Stub;
use Codeception\Stub\Expected; use Codeception\Stub\Expected;
use Codeception\Util\Fixtures; use Codeception\Util\Fixtures;
use MailPoet\API\MP\v1\CustomFields; use MailPoet\API\MP\v1\CustomFields;
use MailPoet\CustomFields\ApiDataSanitizer;
use MailPoet\CustomFields\CustomFieldsRepository; use MailPoet\CustomFields\CustomFieldsRepository;
use MailPoet\Entities\CustomFieldEntity; use MailPoet\Entities\CustomFieldEntity;
use MailPoet\Models\ScheduledTask; use MailPoet\Models\ScheduledTask;

27
tests/integration/API/MP/CustomFieldsTest.php
View File

@@ -3,6 +3,7 @@
namespace MailPoet\Test\API\MP; namespace MailPoet\Test\API\MP;
use MailPoet\API\MP\v1\API; use MailPoet\API\MP\v1\API;
use MailPoet\API\MP\v1\APIException;
use MailPoet\CustomFields\CustomFieldsRepository; use MailPoet\CustomFields\CustomFieldsRepository;
use MailPoet\Entities\CustomFieldEntity; use MailPoet\Entities\CustomFieldEntity;
@@ -80,4 +81,30 @@ class CustomFieldsTest extends \MailPoetTest {
], ],
]); ]);
} }
public function testItCreateNewCustomField() {
$response = $this->api->addSubscriberField([
'name' => 'text custom field',
'type' => 'text',
'params' => [
'required' => '1',
'label' => 'text custom field',
'date_type' => 'year_month_day',
],
]);
expect($response)->array();
expect($response)->hasKey('name');
}
public function testItFailsToCreateNewCustomField() {
$this->expectException(APIException::class);
$this->api->addSubscriberField([
'type' => 'text',
'params' => [
'required' => '1',
'label' => 'text custom field',
'date_type' => 'year_month_day',
],
]);
}
} }