Better naming

[MAILPOET-1976]
This commit is contained in:
Ján Mikláš
2019-05-29 17:16:39 +02:00
committed by M. Shull
parent 16ba2490c9
commit 1bd4e25694

View File

@@ -28,16 +28,16 @@ Module.HistoryView = Marionette.View.extend({
}, },
initialize: function initialize() { initialize: function initialize() {
App.getChannel().on('afterEditorSave', this.setCurrentState, this); App.getChannel().on('afterEditorSave', this.addState, this);
}, },
onAttach: function onRender() { onAttach: function onRender() {
this.elements.redo = jQuery('#mailpoet-history-arrow-redo'); this.elements.redo = jQuery('#mailpoet-history-arrow-redo');
this.elements.undo = jQuery('#mailpoet-history-arrow-undo'); this.elements.undo = jQuery('#mailpoet-history-arrow-undo');
this.setCurrentState(App.toJSON()); this.addState(App.toJSON());
}, },
setCurrentState: function setCurrentState(json) { addState: function addState(json) {
if (!json || !json.body) { if (!json || !json.body) {
return; return;
} }
@@ -51,7 +51,7 @@ Module.HistoryView = Marionette.View.extend({
}, },
canUndo: function canUndo() { canUndo: function canUndo() {
return this.model.currentStateIndex < (this.model.states.length - 1) return this.model.currentStateIndex < (this.model.states.length - 1);
}, },
canRedo: function canRedo() { canRedo: function canRedo() {
@@ -78,11 +78,11 @@ Module.HistoryView = Marionette.View.extend({
if (this.canUndo()) { if (this.canUndo()) {
this.elements.undo.removeClass('mailpoet_history_arrow_inactive'); this.elements.undo.removeClass('mailpoet_history_arrow_inactive');
this.elements.undo.prop('title', MailPoet.I18n.t('canUndo')); this.elements.undo.prop('title', MailPoet.I18n.t('canUndo'));
}; }
if (this.canRedo()) { if (this.canRedo()) {
this.elements.redo.removeClass('mailpoet_history_arrow_inactive'); this.elements.redo.removeClass('mailpoet_history_arrow_inactive');
this.elements.redo.prop('title', MailPoet.I18n.t('canRedo')); this.elements.redo.prop('title', MailPoet.I18n.t('canRedo'));
}; }
}, },
}); });