fixed ErrorResponse call in API::setupPublic()

- removed empty constructors in updated endpoints
- added missing keys to Error class (unauthorized, forbidden)

lib/API/API.php

@@ -37,7 +37,9 @@ class API {
   function setupAdmin() {
     if($this->checkToken() === false) {
       (new ErrorResponse(
-        array('unauthorized' => __('This request is not authorized.')),
+        array(
+          Error::UNAUTHORIZED => __('You need to specify a valid API token.')
+        ),
         array(),
         Response::STATUS_UNAUTHORIZED
       ))->send();
@@ -45,7 +47,9 @@ class API {
 
     if($this->checkPermissions() === false) {
       (new ErrorResponse(
-        array('forbidden' => __('You do not have the required permissions.')),
+        array(
+          Error::FORBIDDEN => __('You do not have the required permissions.')
+        ),
         array(),
         Response::STATUS_FORBIDDEN
       ))->send();
@@ -56,10 +60,13 @@ class API {
 
   function setupPublic() {
     if($this->checkToken() === false) {
-      $response = new ErrorResponse(array(
+      (new ErrorResponse(
-        'unauthorized' => __('This request is not authorized.')
+        array(
-      ), Response::STATUS_UNAUTHORIZED);
+          Error::UNAUTHORIZED => __('You need to specify a valid API token.')
-      $response->send();
+        ),
+        array(),
+        Response::STATUS_UNAUTHORIZED
+      ))->send();
     }
 
     $this->processRoute();
@@ -101,7 +108,9 @@ class API {
         wp_send_json($response);
       }
     } catch(\Exception $e) {
-      (new ErrorResponse(array($e->getMessage())))->send();
+      (new ErrorResponse(
+        array($e->getCode() => $e->getMessage())
+      ))->send();
     }
   }
 

lib/API/Endpoints/Settings.php

@@ -7,9 +7,6 @@ use \MailPoet\Models\Setting;
 if(!defined('ABSPATH')) exit;
 
 class Settings extends APIEndpoint {
-  function __construct() {
-  }
-
   function get() {
     return $this->successResponse(Setting::getAll());
   }

lib/API/Endpoints/Setup.php

@@ -6,9 +6,6 @@ use \MailPoet\Config\Activator;
 if(!defined('ABSPATH')) exit;
 
 class Setup extends APIEndpoint {
-  function __construct() {
-  }
-
   function reset() {
     try {
       $activator = new Activator();

lib/API/Error.php

@@ -6,6 +6,8 @@ if(!defined('ABSPATH')) exit;
 final class Error {
   const UNKNOWN = 'unknown';
   const BAD_REQUEST = 'bad_request';
+  const UNAUTHORIZED = 'unauthorized';
+  const FORBIDDEN = 'forbidden';
 
   private function __construct() {