Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Mark unused old segment model methods as deprecated

Browse Source 
[MAILPOET-3164]
This commit is contained in:
Rostislav Wolny
2021-01-20 16:27:57 +01:00
committed by Veljko V
parent 9868f5cc21
commit 1d7d56af52
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/Models/Segment.php
View File

@@ -87,6 +87,7 @@ class Segment extends Model {
* @return $this * @return $this
*/ */
public function withSubscribersCount() { public function withSubscribersCount() {
trigger_error('Calling Segment::withSubscribersCount() is deprecated and will be removed. Use MailPoet\Segments\SegmentSubscribersRepository::getSubscribersStatisticsCount. ', E_USER_DEPRECATED);
$query = SubscriberSegment::tableAlias('relation') $query = SubscriberSegment::tableAlias('relation')
->where('relation.segment_id', $this->id) ->where('relation.segment_id', $this->id)
->join( ->join(
@@ -204,7 +205,11 @@ class Segment extends Model {
return $orm; return $orm;
} }
/**
* @deprecated Will be removed after 2021/07/30. Use MailPoet\Segments\SegmentsSimpleListRepository
*/
public static function getSegmentsWithSubscriberCount($type = self::TYPE_DEFAULT) { public static function getSegmentsWithSubscriberCount($type = self::TYPE_DEFAULT) {
trigger_error('Calling Segment::getSegmentsWithSubscriberCount() is deprecated and will be removed. Use MailPoet\Segments\SegmentsSimpleListRepository. ', E_USER_DEPRECATED);
$query = self::selectMany([self::$_table . '.id', self::$_table . '.name']) $query = self::selectMany([self::$_table . '.id', self::$_table . '.name'])
->whereIn('type', Segment::getSegmentTypes()) ->whereIn('type', Segment::getSegmentTypes())
->selectExpr( ->selectExpr(
@@ -236,14 +241,22 @@ class Segment extends Model {
return $query->findArray(); return $query->findArray();
} }
/**
* @deprecated Will be removed after 2021/07/30. Use MailPoet\Segments\SegmentsSimpleListRepository
*/
public static function getSegmentsForImport() { public static function getSegmentsForImport() {
trigger_error('Calling Segment::getSegmentsForImport() is deprecated and will be removed. Use MailPoet\Segments\SegmentsSimpleListRepository. ', E_USER_DEPRECATED);
$segments = self::getSegmentsWithSubscriberCount($type = false); $segments = self::getSegmentsWithSubscriberCount($type = false);
return array_values(array_filter($segments, function($segment) { return array_values(array_filter($segments, function($segment) {
return $segment['type'] !== Segment::TYPE_WC_USERS; return $segment['type'] !== Segment::TYPE_WC_USERS;
})); }));
} }
/**
* @deprecated Will be removed after 2021/07/30. Use MailPoet\Segments\SegmentsSimpleListRepository
*/
public static function getSegmentsForExport() { public static function getSegmentsForExport() {
trigger_error('Calling Segment::getSegmentsForExport() is deprecated and will be removed. Use MailPoet\Segments\SegmentsSimpleListRepository. ', E_USER_DEPRECATED);
return self::rawQuery( return self::rawQuery(
'(SELECT segments.id, segments.name, COUNT(relation.subscriber_id) as subscribers ' . '(SELECT segments.id, segments.name, COUNT(relation.subscriber_id) as subscribers ' .
'FROM ' . MP_SUBSCRIBER_SEGMENT_TABLE . ' relation ' . 'FROM ' . MP_SUBSCRIBER_SEGMENT_TABLE . ' relation ' .