Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

editor: Disable update blockDefaults for texts and images

Browse Source
This commit is contained in:
Rostislav Wolny
2018-03-12 15:17:03 +01:00
parent 3a8b64e11c
commit 1df25aef76
4 changed files with 28 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
assets/js/src/newsletter_editor/blocks/image.js
View File

@ -31,7 +31,8 @@ define([
}
}
}, App.getConfig().get('blockDefaults.image'));
}
},
_updateDefaults: function () {}
});
Module.ImageBlockView = base.BlockView.extend({

3
assets/js/src/newsletter_editor/blocks/text.js
View File

@ -18,7 +18,8 @@ define([
type: 'text',
text: 'Edit this to insert text'
}, App.getConfig().get('blockDefaults.text'));
}
},
_updateDefaults: function updateDefaults() {}
});
Module.TextBlockView = base.BlockView.extend({

11
tests/javascript/newsletter_editor/blocks/image.spec.js
View File

@ -10,12 +10,17 @@ define([
describe('Image', function () {
describe('model', function () {
var model;
var sandbox;
beforeEach(function () {
global.stubChannel(EditorApplication);
global.stubConfig(EditorApplication, {
blockDefaults: {}
});
model = new (ImageBlock.ImageBlockModel)();
sandbox = sinon.sandbox.create();
});
afterEach(function () {
sandbox.restore();
});
it('has an image type', function () {
@ -102,6 +107,12 @@ define([
expect(innerModel.get('height')).to.equal('2345px');
expect(innerModel.get('styles.block.textAlign')).to.equal('right');
});
it('do not update blockDefaults.image when changed', function () {
var stub = sandbox.stub(EditorApplication.getConfig(), 'set');
model.trigger('change');
expect(stub.callCount).to.equal(0);
});
});
describe('block view', function () {

13
tests/javascript/newsletter_editor/blocks/text.spec.js
View File

@ -1,4 +1,5 @@
const expect = global.expect;
const sinon = global.sinon;
define([
'newsletter_editor/App',
@ -7,10 +8,16 @@ define([
describe('Text', function () {
describe('model', function () {
var model;
var sandbox;
beforeEach(function () {
global.stubChannel(EditorApplication);
global.stubConfig(EditorApplication);
model = new (TextBlock.TextBlockModel)();
sandbox = sinon.sandbox.create();
});
afterEach(function () {
sandbox.restore();
});
it('has a text type', function () {
@ -33,6 +40,12 @@ define([
expect(model.get('text')).to.equal('some custom config text');
});
it('do not update blockDefaults.text when changed', function () {
var stub = sandbox.stub(EditorApplication.getConfig(), 'set');
model.trigger('change');
expect(stub.callCount).to.equal(0);
});
});
describe('block view', function () {