From 2078ddf2923b047e63baba79809aedff02129f7c Mon Sep 17 00:00:00 2001 From: John Oleksowicz Date: Tue, 11 Jul 2023 15:51:53 -0500 Subject: [PATCH] Save last_subscriber_id as we go Otherwise the task would always be starting at 0 if it times out MAILPOET-5404 --- mailpoet/lib/Cron/Workers/BackfillEngagementData.php | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/mailpoet/lib/Cron/Workers/BackfillEngagementData.php b/mailpoet/lib/Cron/Workers/BackfillEngagementData.php index ee4ee880e0..c4f7f6ce04 100644 --- a/mailpoet/lib/Cron/Workers/BackfillEngagementData.php +++ b/mailpoet/lib/Cron/Workers/BackfillEngagementData.php @@ -32,18 +32,16 @@ class BackfillEngagementData extends SimpleWorker { $this->cronHelper->enforceExecutionLimit($timer); $batch = $this->engagementDataBackfiller->getBatch($lastSubscriberId); if (empty($batch)) { - $this->engagementDataBackfiller->setLastProcessedSubscriberId($lastSubscriberId); break; } $this->engagementDataBackfiller->updateBatch($batch); $lastSubscriberId = $this->engagementDataBackfiller->getLastProcessedSubscriberId(); + $meta['last_subscriber_id'] = $lastSubscriberId; + $task->setMeta($meta); + $this->scheduledTasksRepository->persist($task); + $this->scheduledTasksRepository->flush(); } while (count($batch) === self::BATCH_SIZE); - $meta['last_subscriber_id'] = $this->engagementDataBackfiller->getLastProcessedSubscriberId(); - $task->setMeta($meta); - $this->scheduledTasksRepository->persist($task); - $this->scheduledTasksRepository->flush(); - return true; } }