Upgrade PHPStan level to 4

I had to add some ignore errors until phpstan/phpstan#1482 is resolved

[MAILPOET-1915]

RoboFile.php

@@ -378,7 +378,7 @@ class RoboFile extends \Robo\Tasks {
         'php -d memory_limit=2G '.
         "$dir/phpstan.phar analyse ".
         "--configuration $dir/tasks/phpstan/phpstan.neon ".
-        '--level 3 '.
+        '--level 4 '.
         "$dir/lib"
       )
       ->dir(__DIR__ . '/tasks/phpstan')

lib/Config/RendererFactory.php

@@ -6,7 +6,7 @@ if (!defined('ABSPATH')) exit;
 
 class RendererFactory {
 
-  /** @var Renderer */
+  /** @var Renderer|null */
   private $renderer;
 
   function getRenderer() {

lib/DI/ContainerWrapper.php

@@ -14,7 +14,7 @@ class ContainerWrapper implements ContainerInterface {
   /** @var ContainerInterface|null */
   private $premium_container;
 
-  /** @var ContainerWrapper */
+  /** @var ContainerWrapper|null */
   private static $instance;
 
   public function __construct(ContainerInterface $free_container, ContainerInterface $premium_container = null) {

lib/Models/CustomField.php

@@ -8,7 +8,7 @@ if (!defined('ABSPATH')) exit;
 
 /**
  * @property string $type
- * @property string|array $params
+ * @property string|array|null $params
  */
 
 class CustomField extends Model {

lib/Models/Subscriber.php

@@ -148,7 +148,7 @@ class Subscriber extends Model {
   }
 
   static function search($orm, $search = '') {
-    if (strlen(trim($search) === 0)) {
+    if (strlen(trim($search)) === 0) {
       return $orm;
     }
 

lib/Newsletter/Shortcodes/Categories/Subscriber.php

@@ -9,7 +9,7 @@ if (!defined('ABSPATH')) exit;
 
 class Subscriber {
   /**
-   * @param \MailPoet\Models\Subscriber|false $subscriber
+   * @param \MailPoet\Models\Subscriber|false|mixed $subscriber
    */
   static function process(
     $shortcode_details,

lib/Statistics/Track/Clicks.php

@@ -10,7 +10,7 @@ if (!defined('ABSPATH')) exit;
 
 class Clicks {
   /**
-   * @param \stdClass $data
+   * @param \stdClass|null $data
    */
   function track($data) {
     if (!$data || empty($data->link)) {

lib/Subscribers/ConfirmationEmailMailer.php

@@ -13,7 +13,7 @@ class ConfirmationEmailMailer {
 
   const MAX_CONFIRMATION_EMAILS = 3;
 
-  /** @var Mailer */
+  /** @var Mailer|null */
   private $mailer;
 
   /** @var WPFunctions */

lib/Subscribers/NewSubscriberNotificationMailer.php

@@ -16,7 +16,7 @@ class NewSubscriberNotificationMailer {
   /** @var Renderer */
   private $renderer;
 
-  /** @var \MailPoet\Mailer\Mailer */
+  /** @var \MailPoet\Mailer\Mailer|null */
   private $mailer;
 
   /** @var Functions */

lib/Util/Sudzy/ValidModel.php

@@ -80,9 +80,7 @@ abstract class ValidModel extends \Model {
         $params = explode('|', $check);
         $check  = array_shift($params);
 
-        if ($this->_validator->executeOne($check, $value, $params)) {
+        if (!$this->_validator->executeOne($check, $value, $params)) {
-          $success = $success && true;
-        } else {
           $this->addValidationError($v['message'], $field);
           $success = false;
         }

tasks/phpstan/phpstan.neon

@@ -1,9 +1,11 @@
 parameters:
-	tmpDir: ../../temp/phpstan
+  tmpDir: ../../temp/phpstan
-	bootstrap: bootstrap.php
+  bootstrap: bootstrap.php
-	ignoreErrors:
+  ignoreErrors:
-		- '#Function members_register_.+ not found#'
+    - '#Function members_register_.+ not found#'
-		- '#MailPoet\\Premium\\DI\\ContainerConfigurator not found#' # this class is not available when premium is not active
+    - '#MailPoet\\Premium\\DI\\ContainerConfigurator not found#' # this class is not available when premium is not active
-		- '#Call to an undefined method IdiormResultSet::set()#'
+    - '#Call to an undefined method IdiormResultSet::set()#'
-		- '#Argument of an invalid type pQuery\\IQuery supplied for foreach, only iterables are supported#'
+    - '#Argument of an invalid type pQuery\\IQuery supplied for foreach, only iterables are supported#'
-	reportUnmatchedIgnoredErrors: false
+  reportUnmatchedIgnoredErrors: false
+  dynamicConstantNames:
+    - WP_DEBUG