Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add subscriber errors passing via MailerError object

Browse Source 
We want to process errors for individual subscribers.
Subscriber errors were inlined into error message string.
This commit changes this so that we are now able to get
subscriber errors as a data which are easy to process further.

[MAILPOET-1154]
This commit is contained in:
Rostislav Wolny
2018-09-05 13:11:59 +02:00
parent 0923c892c1
commit 223c2e1562
12 changed files with 197 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/unit/Mailer/Methods/ErrorMappers/MailPoetMapperTest.php
View File

@@ -62,7 +62,7 @@ class MailPoetMapperTest extends \MailPoetTest {
expect($error)->isInstanceOf(MailerError::class);
expect($error->getOperation())->equals(MailerError::OPERATION_SEND);
expect($error->getLevel())->equals(MailerError::LEVEL_HARD);
expect($error->getMessage())->equals('Error while sending newsletters. Api Error');
expect($error->getMessage())->equals('Error while sending. Api Error');
}
function testGetPayloadErrorWithErrorMessage() {
@@ -75,6 +75,24 @@ class MailPoetMapperTest extends \MailPoetTest {
expect($error)->isInstanceOf(MailerError::class);
expect($error->getOperation())->equals(MailerError::OPERATION_SEND);
expect($error->getLevel())->equals(MailerError::LEVEL_HARD);
expect($error->getMessage())->equals('Error while sending: (a@example.com: subject is missing), (c d <b@example.com>: subject is missing)');
$subscriber_errors = $error->getSubscriberErrors();
expect(count($subscriber_errors))->equals(2);
expect($subscriber_errors[0]->getEmail())->equals('a@example.com');
expect($subscriber_errors[0]->getMessage())->equals('subject is missing');
expect($subscriber_errors[1]->getEmail())->equals('c d <b@example.com>');
expect($subscriber_errors[1]->getMessage())->equals('subject is missing');
}
function testGetPayloadErrorForMalformedMSSResponse() {
$api_result = [
'code' => API::RESPONSE_CODE_PAYLOAD_ERROR,
'status' => API::SENDING_STATUS_SEND_ERROR,
'message' => '[{"errors":{"subject":"subject is missing"}},{"errors":{"subject":"subject is missing"}}]'
];
$error = $this->mapper->getErrorForResult($api_result, $this->subscribers);
expect($error)->isInstanceOf(MailerError::class);
expect($error->getOperation())->equals(MailerError::OPERATION_SEND);
expect($error->getLevel())->equals(MailerError::LEVEL_HARD);
expect($error->getMessage())->equals('Error while sending. Invalid MSS response format.');
}
}