Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Mark network tests as skipped

Browse Source 
Instead of silently returning

[MAILPOET-2358]
This commit is contained in:
Pavel Dohnal
2019-09-17 15:11:37 +02:00
committed by Jack Kitterhing
parent 3b390e9d88
commit 227ec2adc9
4 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/integration/Cron/CronHelperTest.php
View File

@ -228,7 +228,7 @@ class CronHelperTest extends \MailPoetTest {
$site_url = 'http://example.com'; $site_url = 'http://example.com';
expect(CronHelper::getSiteUrl($site_url))->equals($site_url); expect(CronHelper::getSiteUrl($site_url))->equals($site_url);
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
// 2. when url contains valid port, try connecting to it // 2. when url contains valid port, try connecting to it
$site_url = 'http://example.com:80'; $site_url = 'http://example.com:80';
@ -308,7 +308,7 @@ class CronHelperTest extends \MailPoetTest {
} }
function testItPingsDaemon() { function testItPingsDaemon() {
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
// raw response is returned // raw response is returned
expect(CronHelper::pingDaemon())->equals(DaemonHttpRunner::PING_SUCCESS_RESPONSE); expect(CronHelper::pingDaemon())->equals(DaemonHttpRunner::PING_SUCCESS_RESPONSE);
} }

12
tests/integration/Cron/SupervisorTest.php
View File

@ -23,34 +23,34 @@ class SupervisorTest extends \MailPoetTest {
} }
function testItCanConstruct() { function testItCanConstruct() {
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
$supervisor = new Supervisor(); $supervisor = new Supervisor();
expect($supervisor->token)->notEmpty(); expect($supervisor->token)->notEmpty();
expect($supervisor->daemon)->notEmpty(); expect($supervisor->daemon)->notEmpty();
} }
function testItCreatesDaemonWhenOneDoesNotExist() { function testItCreatesDaemonWhenOneDoesNotExist() {
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
expect($this->settings->get(CronHelper::DAEMON_SETTING))->null(); expect($this->settings->get(CronHelper::DAEMON_SETTING))->null();
$supervisor = new Supervisor(); $supervisor = new Supervisor();
expect($supervisor->getDaemon())->notEmpty(); expect($supervisor->getDaemon())->notEmpty();
} }
function testItReturnsDaemonWhenOneExists() { function testItReturnsDaemonWhenOneExists() {
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
$supervisor = new Supervisor(); $supervisor = new Supervisor();
expect($supervisor->getDaemon())->equals($supervisor->daemon); expect($supervisor->getDaemon())->equals($supervisor->daemon);
} }
function testItDoesNothingWhenDaemonExecutionDurationIsBelowLimit() { function testItDoesNothingWhenDaemonExecutionDurationIsBelowLimit() {
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
$supervisor = new Supervisor(); $supervisor = new Supervisor();
expect($supervisor->checkDaemon()) expect($supervisor->checkDaemon())
->equals($supervisor->daemon); ->equals($supervisor->daemon);
} }
function testRestartsDaemonWhenExecutionDurationIsAboveLimit() { function testRestartsDaemonWhenExecutionDurationIsAboveLimit() {
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
$supervisor = new Supervisor(); $supervisor = new Supervisor();
$supervisor->daemon['updated_at'] = time() - CronHelper::DAEMON_EXECUTION_TIMEOUT; $supervisor->daemon['updated_at'] = time() - CronHelper::DAEMON_EXECUTION_TIMEOUT;
$daemon = $supervisor->checkDaemon(); $daemon = $supervisor->checkDaemon();
@ -60,7 +60,7 @@ class SupervisorTest extends \MailPoetTest {
} }
function testRestartsDaemonWhenItIsInactive() { function testRestartsDaemonWhenItIsInactive() {
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
$supervisor = new Supervisor(); $supervisor = new Supervisor();
$supervisor->daemon['updated_at'] = time(); $supervisor->daemon['updated_at'] = time();
$supervisor->daemon['status'] = CronHelper::DAEMON_STATUS_INACTIVE; $supervisor->daemon['status'] = CronHelper::DAEMON_STATUS_INACTIVE;

2
tests/integration/Services/BridgeTest.php
View File

@ -260,7 +260,7 @@ class BridgeTest extends \MailPoetTest {
} }
function testItPingsBridge() { function testItPingsBridge() {
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
expect(Bridge::pingBridge())->true(); expect(Bridge::pingBridge())->true();
} }

10
tests/unit/Subscribers/ImportExport/Import/MailChimpTest.php
View File

@ -47,7 +47,7 @@ class MailChimpTest extends \MailPoetUnitTest {
} }
function testItFailsWithIncorrectAPIKey() { function testItFailsWithIncorrectAPIKey() {
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
try { try {
$mailchimp = clone($this->mailchimp); $mailchimp = clone($this->mailchimp);
@ -60,7 +60,7 @@ class MailChimpTest extends \MailPoetUnitTest {
} }
function testItCanGetLists() { function testItCanGetLists() {
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
try { try {
$lists = $this->mailchimp->getLists(); $lists = $this->mailchimp->getLists();
} catch (\Exception $e) { } catch (\Exception $e) {
@ -72,7 +72,7 @@ class MailChimpTest extends \MailPoetUnitTest {
} }
function testItFailsWithIncorrectLists() { function testItFailsWithIncorrectLists() {
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
try { try {
$this->mailchimp->getSubscribers(); $this->mailchimp->getSubscribers();
@ -90,7 +90,7 @@ class MailChimpTest extends \MailPoetUnitTest {
} }
function testItCanGetSubscribers() { function testItCanGetSubscribers() {
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
try { try {
$subscribers = $this->mailchimp->getSubscribers([$this->lists[0]]); $subscribers = $this->mailchimp->getSubscribers([$this->lists[0]]);
@ -106,7 +106,7 @@ class MailChimpTest extends \MailPoetUnitTest {
} }
function testItFailsWhenSubscribersDataTooLarge() { function testItFailsWhenSubscribersDataTooLarge() {
if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') return; if (getenv('WP_TEST_ENABLE_NETWORK_TESTS') !== 'true') $this->markTestSkipped();
$mailchimp = clone($this->mailchimp); $mailchimp = clone($this->mailchimp);
$mailchimp->max_post_size = 10; $mailchimp->max_post_size = 10;