Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Merge pull request #980 from mailpoet/newsletter_listing_update

Browse Source 
Sorts standard/history notification records by sent_at date in listings [MAILPOET-932]
This commit is contained in:
Tautvidas Sipavičius
2017-07-11 12:43:06 +03:00
committed by GitHub
parent 23d90c9f73 24e682e92e
commit 22bb971db5
12 changed files with 216 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
tests/unit/API/JSON/v1/NewslettersTest.php
View File

@@ -31,6 +31,51 @@ class NewslettersTest extends MailPoetTest {
));
}
function testItKeepsUnsentNewslettersAtTheTopWhenSortingBySentAtDate() {
$router = new Newsletters();
$sent_newsletters = array();
for($i = 1; $i <= 3; $i++) {
$sent_newsletters[$i] = Newsletter::create();
$sent_newsletters[$i]->type = Newsletter::TYPE_STANDARD;
$sent_newsletters[$i]->subject = 'Sent newsletter ' . $i;
$sent_newsletters[$i]->sent_at = '2017-01-0' . $i . ' 01:01:01';
$sent_newsletters[$i]->save();
};
// sorting by ASC order retains unsent newsletters at the top
$response = $router->listing(
array(
'params' => array(
'type' => 'standard'
),
'sort_by' => 'sent_at',
'sort_order' => 'asc'
)
);
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data[0]['id'])->equals($this->newsletter->id);
expect($response->data[1]['id'])->equals($sent_newsletters[1]->id);
expect($response->data[2]['id'])->equals($sent_newsletters[2]->id);
expect($response->data[3]['id'])->equals($sent_newsletters[3]->id);
// sorting by DESC order retains unsent newsletters at the top
$response = $router->listing(
array(
'params' => array(
'type' => 'standard'
),
'sort_by' => 'sent_at',
'sort_order' => 'desc'
)
);
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data[0]['id'])->equals($this->newsletter->id);
expect($response->data[1]['id'])->equals($sent_newsletters[3]->id);
expect($response->data[2]['id'])->equals($sent_newsletters[2]->id);
expect($response->data[3]['id'])->equals($sent_newsletters[1]->id);
}
function testItCanGetANewsletter() {
$router = new Newsletters();