diff --git a/assets/js/src/newsletter_editor/blocks/divider.js b/assets/js/src/newsletter_editor/blocks/divider.js index 38549a588b..e85454e76c 100644 --- a/assets/js/src/newsletter_editor/blocks/divider.js +++ b/assets/js/src/newsletter_editor/blocks/divider.js @@ -126,6 +126,7 @@ Module.DividerBlockSettingsView = base.BlockSettingsView.extend({ }); Module.DividerWidgetView = base.WidgetView.extend({ + id: 'automation_editor_block_divider', getTemplate: function getTemplate() { return window.templates.dividerInsertion; }, behaviors: { DraggableBehavior: { diff --git a/tests/acceptance/EditorDividerBlockCest.php b/tests/acceptance/EditorDividerBlockCest.php new file mode 100644 index 0000000000..e436314cb0 --- /dev/null +++ b/tests/acceptance/EditorDividerBlockCest.php @@ -0,0 +1,38 @@ +wantTo('add divider block to newsletter'); + $newsletterTitle = 'Divider Block Newsletter'; + $dividerSettings = ('[data-automation-id="settings_tool"]'); + $dividerResizeHandle = ('[data-automation-id="divider_resize_handle"]'); + $dividerInEditor = ('[data-automation-id="divider"]'); + $dividerSettingsAssertion = ('[data-automation-id="divider_selector"]'); + (new Newsletter()) + ->withSubject($newsletterTitle) + ->loadBodyFrom('newsletterWithText.json') + ->create(); + $I->login(); + $I->amOnMailpoetPage('Emails'); + $I->waitForText($newsletterTitle); + $I->clickItemRowActionByItemName($newsletterTitle, 'Edit'); + // Create divider block + $I->waitForText('Divider'); + $I->wait(1); // just to be sure + $I->dragAndDrop('#automation_editor_block_divider', '#mce_0'); + //Open settings + $I->moveMouseOver($dividerInEditor); + $I->waitForElementVisible($dividerResizeHandle); + $I->waitForElementVisible($dividerSettings); + $I->click($dividerSettings); + $I->waitForElementVisible($dividerSettingsAssertion); + $I->click('Done'); + } + +} diff --git a/views/newsletter/templates/blocks/divider/block.hbs b/views/newsletter/templates/blocks/divider/block.hbs index 0bc076f764..94e0c63a6f 100644 --- a/views/newsletter/templates/blocks/divider/block.hbs +++ b/views/newsletter/templates/blocks/divider/block.hbs @@ -1,8 +1,8 @@
-
+
-
+
{{ totalHeight }} <%= source('newsletter/templates/svg/block-icons/spacer.svg') %>
diff --git a/views/newsletter/templates/blocks/divider/settings.hbs b/views/newsletter/templates/blocks/divider/settings.hbs index 23b920c575..5259a7b6dc 100644 --- a/views/newsletter/templates/blocks/divider/settings.hbs +++ b/views/newsletter/templates/blocks/divider/settings.hbs @@ -1,5 +1,5 @@

<%= __('Dividers') %>

-
+
{{#each availableStyles.dividers}}