Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Move segment id validation to private method

Browse Source 
[MAILPOET-4752]
This commit is contained in:
Jan Lysý
2022-10-26 18:17:03 +02:00
committed by Aschepikov
parent 1ac9c86a66
commit 25ba667cb1
1 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
mailpoet/lib/API/MP/v1/Segments.php
View File

@@ -43,19 +43,7 @@ class Segments {
public function updateList(array $data): array {
// firstly validation on list id
if (empty($data['id'])) {
throw new APIException(
__('List id is required.', 'mailpoet'),
APIException::LIST_ID_REQUIRED
);
}
if (!$this->segmentsRepository->findOneById((string)$data['id'])) {
throw new APIException(
__('The list does not exist.', 'mailpoet'),
APIException::LIST_NOT_EXISTS
);
}
$this->validateSegmentId((string)($data['id'] ?? ''));
// secondly validation on list name
$this->validateSegmentName($data);
@@ -78,6 +66,22 @@ class Segments {
return $this->buildItem($segment);
}
private function validateSegmentId(string $segmentId): void {
if (empty($segmentId)) {
throw new APIException(
__('List id is required.', 'mailpoet'),
APIException::LIST_ID_REQUIRED
);
}
if (!$this->segmentsRepository->findOneById($segmentId)) {
throw new APIException(
__('The list does not exist.', 'mailpoet'),
APIException::LIST_NOT_EXISTS
);
}
}
/**
* Throws an exception when the segment's name is invalid
* @return void