Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Use try-finally for delete transient on error

Browse Source 
[MAILPOET-3656]
This commit is contained in:
Jan Lysý
2021-06-11 12:46:09 +02:00
committed by Veljko V
parent a5b964c785
commit 2b43531c59
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Config/Activator.php
View File

@@ -29,8 +29,11 @@ class Activator {
$isRunning = $this->wp->getTransient(self::TRANSIENT_ACTIVATE_KEY); $isRunning = $this->wp->getTransient(self::TRANSIENT_ACTIVATE_KEY);
if ($isRunning === false) { if ($isRunning === false) {
$this->wp->setTransient(self::TRANSIENT_ACTIVATE_KEY, '1', self::TRANSIENT_EXPIRATION); $this->wp->setTransient(self::TRANSIENT_ACTIVATE_KEY, '1', self::TRANSIENT_EXPIRATION);
$this->processActivate(); try {
$this->wp->deleteTransient(self::TRANSIENT_ACTIVATE_KEY); $this->processActivate();
} finally {
$this->wp->deleteTransient(self::TRANSIENT_ACTIVATE_KEY);
}
} else { } else {
throw new InvalidStateException(__('MailPoet version update is in progress, please refresh the page in a minute.', 'mailpoet')); throw new InvalidStateException(__('MailPoet version update is in progress, please refresh the page in a minute.', 'mailpoet'));
} }