;
}
return null;
@@ -48,5 +74,8 @@ export function DaysPeriodField({ filterIndex }: FilterProps): JSX.Element {
}
export function validateDaysPeriod(formItems: DaysPeriodItem): boolean {
+ if (formItems.timeframe === 'allTime') {
+ return true;
+ }
return !!formItems.days;
}
diff --git a/mailpoet/assets/js/src/segments/dynamic/types.ts b/mailpoet/assets/js/src/segments/dynamic/types.ts
index 1ab24d839b..b9968c2993 100644
--- a/mailpoet/assets/js/src/segments/dynamic/types.ts
+++ b/mailpoet/assets/js/src/segments/dynamic/types.ts
@@ -80,6 +80,7 @@ export interface DateFormItem extends FormItem {
export interface DaysPeriodItem extends FormItem {
days?: string;
+ timeframe?: string;
}
export interface TextFormItem extends FormItem {
@@ -156,7 +157,8 @@ export type AnyFormItem =
| WooCommerceFormItem
| WooCommerceSubscriptionFormItem
| WooCommerceMembershipFormItem
- | EmailFormItem;
+ | EmailFormItem
+ | DaysPeriodItem;
export interface SubscriberCount {
count?: number;
diff --git a/mailpoet/views/segments/translations.html b/mailpoet/views/segments/translations.html
index 78623b5b85..83bc31b46c 100644
--- a/mailpoet/views/segments/translations.html
+++ b/mailpoet/views/segments/translations.html
@@ -107,7 +107,7 @@
'emailActionMachineOpensAbsoluteCount': __('number of machine-opens'),
'emailActionOpens': __('opens'),
'emailActionOpensSentence': _x('{condition} {opens} opens', 'The result will be "more than 20 opens"'),
- 'emailActionOpensDaysSentence': _x('in the last {days} days', 'The result will be "in the last 5 days"'),
+ 'emailActionOpensDaysSentence': _x('{timeframe} {days} days', 'The result will be "in the last 5 days"'),
'moreThan': __('more than'),
'lessThan': __('less than'),
'higherThan': __('higher than'),
@@ -147,6 +147,7 @@
'notOn': _x('not on', 'Meaning: "Subscriber subscribed on a date other than the given date"'),
'inTheLast': _x('in the last', 'Meaning: "Subscriber subscribed in the last 3 days"'),
'notInTheLast': _x('not in the last', 'Meaning: "Subscriber subscribed not in the last 3 days"'),
+ 'overAllTime': __('over all time'),
'emailActionNotOpened': _x('not opened', 'Dynamic segment creation: when newsletter was not opened'),
'emailActionClicked': _x('clicked', 'Dynamic segment creation: when a newsletter link was clicked'),