Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Deleted TODOs after noting them as JIRA issues

Browse Source
This commit is contained in:
Fred. P
2018-06-13 14:43:39 +02:00
parent 1005990588
commit 2ee77e0034
4 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Newsletter/Renderer/Renderer.php
View File

@ -19,7 +19,6 @@ class Renderer {
const FILTER_POST_PROCESS = 'mailpoet_rendering_post_process'; const FILTER_POST_PROCESS = 'mailpoet_rendering_post_process';
function __construct($newsletter, $preview = false) { function __construct($newsletter, $preview = false) {
// TODO: remove ternary condition, refactor to use model objects
$this->newsletter = (is_object($newsletter)) ? $newsletter->asArray() : $newsletter; $this->newsletter = (is_object($newsletter)) ? $newsletter->asArray() : $newsletter;
$this->preview = $preview; $this->preview = $preview;
$this->blocks_renderer = new Blocks\Renderer($this->newsletter, $this->preview); $this->blocks_renderer = new Blocks\Renderer($this->newsletter, $this->preview);
@ -210,4 +209,4 @@ class Renderer {
); );
return $content; return $content;
} }
} }

3
lib/Subscription/Manage.php
View File

@ -26,7 +26,6 @@ class Manage {
} }
} }
// TODO: success/error messages (not present in MP2)
Url::redirectBack(); Url::redirectBack();
} }
} }

1
tests/javascript/mochaTestHelper.js
View File

@ -52,7 +52,6 @@ jQuery.fn.spectrum = global.spectrum;
jQuery.fn.stick_in_parent = function () { return this; }; jQuery.fn.stick_in_parent = function () { return this; };
// Add global stubs for convenience // Add global stubs for convenience
// TODO: Extract those to a separate file
global.stubChannel = function (EditorApplication, returnObject) { global.stubChannel = function (EditorApplication, returnObject) {
var App = EditorApplication; var App = EditorApplication;
App.getChannel = sinon.stub().returns(_.defaults(returnObject || {}, { App.getChannel = sinon.stub().returns(_.defaults(returnObject || {}, {

3
views/settings/basics.html
View File

@ -81,7 +81,6 @@
</td> </td>
</tr> </tr>
<!-- ability to subscribe in comments --> <!-- ability to subscribe in comments -->
<!-- TODO: Check if registration is enabled (if not, display a message and disable setting) -->
<tr> <tr>
<th scope="row"> <th scope="row">
<label for="settings[subscribe_on_comment]"> <label for="settings[subscribe_on_comment]">
@ -140,8 +139,6 @@
</td> </td>
</tr> </tr>
<!-- ability to subscribe when registering --> <!-- ability to subscribe when registering -->
<!-- TODO: Only available for the main site of a multisite! -->
<!-- TODO: Check if registration is enabled (if not, display a message and disable setting) -->
<tr> <tr>
<th scope="row"> <th scope="row">
<label for="settings[subscribe_on_register]"> <label for="settings[subscribe_on_register]">