Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Make segment description mandatory

Browse Source 
[MAILPOET-3077]
This commit is contained in:
Rostislav Wolny
2020-09-24 14:41:55 +02:00
committed by Veljko V
parent c78922c12e
commit 2f270575f3
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Entities/SegmentEntity.php
View File

@ -50,7 +50,7 @@ class SegmentEntity {
*/ */
private $dynamicFilters; private $dynamicFilters;
public function __construct(string $name, string $type, string $description = '') { public function __construct(string $name, string $type, string $description) {
$this->name = $name; $this->name = $name;
$this->type = $type; $this->type = $type;
$this->description = $description; $this->description = $description;

2
tests/integration/Newsletter/NewsletterRepositoryTest.php
View File

@ -259,7 +259,7 @@ class NewsletterRepositoryTest extends \MailPoetTest {
$this->entityManager->persist($queue); $this->entityManager->persist($queue);
$newsletter->getQueues()->add($queue); $newsletter->getQueues()->add($queue);
$segment = new SegmentEntity("List for newsletter id {$newsletter->getId()}", SegmentEntity::TYPE_DEFAULT); $segment = new SegmentEntity("List for newsletter id {$newsletter->getId()}", SegmentEntity::TYPE_DEFAULT, 'Description');
$this->entityManager->persist($segment); $this->entityManager->persist($segment);
$subscriber = new SubscriberEntity(); $subscriber = new SubscriberEntity();

2
tests/integration/Segments/DynamicSegments/Filters/EmailActionTest.php
View File

@ -180,7 +180,7 @@ class EmailActionTest extends \MailPoetTest {
private function getSegmentFilter(string $action, int $newsletterId, int $linkId = null): DynamicSegmentFilterEntity { private function getSegmentFilter(string $action, int $newsletterId, int $linkId = null): DynamicSegmentFilterEntity {
return new DynamicSegmentFilterEntity( return new DynamicSegmentFilterEntity(
new SegmentEntity('segment', SegmentEntity::TYPE_DYNAMIC), new SegmentEntity('segment', SegmentEntity::TYPE_DYNAMIC, 'Description'),
[ [
'segmentType' => DynamicSegmentFilterEntity::TYPE_EMAIL, 'segmentType' => DynamicSegmentFilterEntity::TYPE_EMAIL,
'action' => $action, 'action' => $action,

2
tests/integration/Segments/DynamicSegments/Filters/UserRoleTest.php
View File

@ -67,7 +67,7 @@ class UserRoleTest extends \MailPoetTest {
private function getSegmentFilter(string $role): DynamicSegmentFilterEntity { private function getSegmentFilter(string $role): DynamicSegmentFilterEntity {
return new DynamicSegmentFilterEntity( return new DynamicSegmentFilterEntity(
new SegmentEntity('segment', SegmentEntity::TYPE_DYNAMIC), new SegmentEntity('segment', SegmentEntity::TYPE_DYNAMIC, 'Description'),
[ [
'segmentType' => DynamicSegmentFilterEntity::TYPE_USER_ROLE, 'segmentType' => DynamicSegmentFilterEntity::TYPE_USER_ROLE,
'wordpressRole' => $role, 'wordpressRole' => $role,