From 34e4203b9f54b644b992e69f8cf9dd6523901517 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Jakes=CC=8C?= <jan@jakes.pro>
Date: Fri, 19 Apr 2019 13:35:07 +0200
Subject: [PATCH] Move release commands to a namespace & improve naming

[MAILPOET-1977]
---
 RoboFile.php | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/RoboFile.php b/RoboFile.php
index af0ad1b540..6db871b2b3 100644
--- a/RoboFile.php
+++ b/RoboFile.php
@@ -513,14 +513,14 @@ class RoboFile extends \Robo\Tasks {
       ->run();
   }
 
-  function changelogUpdate($opts = ['version-name' => null]) {
+  function releaseChangelogWrite($opts = ['version-name' => null]) {
     $this->say("Updating changelog");
     $outputs = $this->getChangelogController()->update($opts['version-name']);
     $this->say("Changelog \n{$outputs[0]} \n{$outputs[1]}\n\n");
     $this->say("IMPORTANT NOTES \n" . ($outputs[2] ?: 'none'));
   }
 
-  function changelogGet($opts = ['version-name' => null]) {
+  function releaseChangelogGet($opts = ['version-name' => null]) {
     $outputs = $this->getChangelogController()->get($opts['version-name']);
     $this->say("Changelog \n{$outputs[0]} \n{$outputs[1]}\n");
     $this->say("IMPORTANT NOTES \n" . ($outputs[2] ?: 'none'));
@@ -534,7 +534,7 @@ class RoboFile extends \Robo\Tasks {
       ->run();
   }
 
-  public function writeReleaseVersion($version) {
+  public function releaseVersionWrite($version) {
     $version = trim($version);
     $this->validateVersion($version);
 
@@ -554,7 +554,7 @@ class RoboFile extends \Robo\Tasks {
       ->run();
   }
 
-  public function nextReleaseVersion($version = null) {
+  public function releaseVersionGetNext($version = null) {
     if (!$version) {
       $version = $this->getReleaseVersionController()
         ->determineNextVersion();
@@ -563,8 +563,8 @@ class RoboFile extends \Robo\Tasks {
     return $version;
   }
 
-  public function jiraReleaseVersion($version = null, $opts = []) {
-    $version = $this->nextReleaseVersion($version);
+  public function releaseVersionAssign($version = null, $opts = []) {
+    $version = $this->releaseVersionGetNext($version);
     try {
       list($version, $output) = $this->getReleaseVersionController()
         ->assignVersionToCompletedTickets($version);
@@ -579,14 +579,14 @@ class RoboFile extends \Robo\Tasks {
   }
 
   public function prepareRelease($version = null) {
-    $version = $this->jiraReleaseVersion($version, ['return' => true]);
+    $version = $this->releaseVersionAssign($version, ['return' => true]);
 
     return $this->collectionBuilder()
       ->addCode(function () use ($version) {
-        return $this->writeReleaseVersion($version);
+        return $this->releaseVersionWrite($version);
       })
       ->addCode(function () use ($version) {
-        return $this->changelogUpdate(['version-name' => $version]);
+        return $this->releaseChangelogWrite(['version-name' => $version]);
       })
       ->run();
   }
@@ -623,7 +623,7 @@ class RoboFile extends \Robo\Tasks {
   }
 
   public function releasePublishJira($version = null) {
-    $version = $this->nextReleaseVersion($version);
+    $version = $this->releaseVersionGetNext($version);
     $jira_controller = $this->createJiraController();
     $jira_version = $jira_controller->releaseVersion($version);
     $this->say("JIRA version '$jira_version[name]' was released.");