Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove unnecessary type checks

Browse Source 
These were added during initial testing of php8 compatibility using PHPStan and were false positive due PHPStan issues.
[MAILPOET-2837]
This commit is contained in:
Rostislav Wolny
2020-12-30 13:59:43 +01:00
committed by Veljko V
parent 8b58167ed9
commit 35a25e119f
4 changed files with 4 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/Doctrine/Driver/PDOConnection.php
View File

@@ -3,7 +3,6 @@
namespace MailPoet\Doctrine\Driver;
use MailPoet\InvalidStateException;
use MailPoet\RuntimeException;
class PDOConnection implements \MailPoetVendor\Doctrine\DBAL\Driver\Connection, \MailPoetVendor\Doctrine\DBAL\Driver\ServerInfoAwareConnection {
/** @var \PDO */
@@ -51,9 +50,6 @@ class PDOConnection implements \MailPoetVendor\Doctrine\DBAL\Driver\Connection,
public function prepare($prepareString, $driverOptions = []) {
try {
$preparedStatement = $this->connection->prepare($prepareString, $driverOptions);
if ($preparedStatement === false) {
throw new RuntimeException('Unable to prepare PDOStatement.');
}
return $this->createStatement($preparedStatement);
} catch (\PDOException $exception) {
throw new \MailPoetVendor\Doctrine\DBAL\Driver\PDOException($exception);
@@ -99,14 +95,9 @@ class PDOConnection implements \MailPoetVendor\Doctrine\DBAL\Driver\Connection,
public function lastInsertId($name = null) {
try {
if ($name === null) {
$lastId = $this->connection->lastInsertId();
} else {
$lastId = $this->connection->lastInsertId($name);
return $this->connection->lastInsertId();
}
if ($lastId === false) {
return '';
}
return $lastId;
return $this->connection->lastInsertId($name);
} catch (\PDOException $exception) {
throw new \MailPoetVendor\Doctrine\DBAL\Driver\PDOException($exception);
}