Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add 'Bounced' status to subscribers [MAILPOET-684]

Browse Source 
Fix SubscriberTest->testItHasGroupFilter() making only one of four assertions due to lack of data.
Fix a small issue with Import. Unexpected values for the status field were converted to 'unconfirmed' rather than 'subscribed' due to non-strict comparison in in_array(). This hindered 'bounced' status import as well.
This commit is contained in:
Alexey Stoletniy
2016-11-28 19:37:47 +03:00
parent 299c922cef
commit 36b935b9ae
14 changed files with 89 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/Subscribers/ImportExport/Import/Import.php
View File

@ -302,18 +302,24 @@ class Import {
-1,
'-1',
'false'
),
'bounced' => array(
'bounced'
)
);
$subscribers_data['status'] = array_map(function($state) use ($statuses) {
if(in_array(strtolower($state), $statuses['subscribed'])) {
if(in_array(strtolower($state), $statuses['subscribed'], true)) {
return 'subscribed';
}
if(in_array(strtolower($state), $statuses['unsubscribed'])) {
if(in_array(strtolower($state), $statuses['unsubscribed'], true)) {
return 'unsubscribed';
}
if(in_array(strtolower($state), $statuses['unconfirmed'])) {
if(in_array(strtolower($state), $statuses['unconfirmed'], true)) {
return 'unconfirmed';
}
if(in_array(strtolower($state), $statuses['bounced'], true)) {
return 'bounced';
}
return 'subscribed'; // make "subscribed" a default status
}, $subscribers_data['status']);
return array(