Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add 'Bounced' status to subscribers [MAILPOET-684]

Browse Source 
Fix SubscriberTest->testItHasGroupFilter() making only one of four assertions due to lack of data.
Fix a small issue with Import. Unexpected values for the status field were converted to 'unconfirmed' rather than 'subscribed' due to non-strict comparison in in_array(). This hindered 'bounced' status import as well.
This commit is contained in:
Alexey Stoletniy
2016-11-28 19:37:47 +03:00
parent 299c922cef
commit 36b935b9ae
14 changed files with 89 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/unit/Newsletter/ShortcodesTest.php
View File

@@ -153,7 +153,12 @@ class ShortcodesTest extends MailPoetTest {
$this->subscriber->save();
$result =
$shortcodes_object->process(array('[subscriber:count]'));
expect($result[0])->equals(--$subscriber_count);
expect($result[0])->equals($subscriber_count - 1);
$this->subscriber->status = 'bounced';
$this->subscriber->save();
$result =
$shortcodes_object->process(array('[subscriber:count]'));
expect($result[0])->equals($subscriber_count - 1);
}
function testItCanProcessSubscriberCustomFieldShortcodes() {